Beta fixes#10728
Merged
Merged
Conversation
Contributor
⚡ Try this PR in the Web Flasher
Warning This is an automated, unreviewed CI test build. Back up your device configuration Supported boards built by this PR (22)
Build artifacts expire on 2026-07-17. Updated for |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR applies a couple of small firmware fixes discovered during beta device testing, focused on messaging UX correctness and ensuring factory reset fully clears persisted on-device message history (for screen builds).
Changes:
- Treat
NodeNum == 0as broadcast when launching the Canned Message UI flow, preventing attempts to send to an invalid/reserved node ID. - Clear the on-device
MessageStoreduringNodeDB::factoryReset()(screen builds) so message history does not survive a factory reset.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/modules/CannedMessageModule.cpp | Maps newDest == 0 to NODENUM_BROADCAST in canned/freetext launch paths to avoid invalid direct destinations. |
| src/mesh/NodeDB.cpp | Clears persisted message history during factory reset (screen builds) via messageStore.clearAllMessages(). |
jp-bennett
commented
Jun 16, 2026
jp-bennett
added a commit
that referenced
this pull request
Jun 17, 2026
* Wipe message Store on factory reset * Check for destination 0 in a new message, and convert to broadcast * Make sure CHARGE_LED_state gets turned off, to avoid stuck LEDs * Take the spiLock in MessageStore when clearing messages * Trunk * Add thinknode M5 voltage curve * Fix the oops
indoor-industry
pushed a commit
to indoor-industry/meshtastic-firmware-mercurio_v1
that referenced
this pull request
Jun 18, 2026
* Wipe message Store on factory reset * Check for destination 0 in a new message, and convert to broadcast * Make sure CHARGE_LED_state gets turned off, to avoid stuck LEDs * Take the spiLock in MessageStore when clearing messages * Trunk * Add thinknode M5 voltage curve * Fix the oops
raghumad
pushed a commit
to raghumad/mezulla-firmware
that referenced
this pull request
Jun 25, 2026
* Wipe message Store on factory reset * Check for destination 0 in a new message, and convert to broadcast * Make sure CHARGE_LED_state gets turned off, to avoid stuck LEDs * Take the spiLock in MessageStore when clearing messages * Trunk * Add thinknode M5 voltage curve * Fix the oops
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Possibly more to come, just a few fixes for issues found while testing the upcoming Beta on my devices.