Lora led rx#10674
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds an LED_LORA activity indicator path intended to flash an LED on LoRa packet reception (and currently also toggles it on TX) for the Elecrow ThinkNode M7, by plumbing a receive observable from the radio driver into StatusLEDModule.
Changes:
- Initialize
LED_LORAGPIO in the Elecrow ThinkNode M7 variant init. - Add a
RadioInterface::loraRxPacketObservableand notify it on successful LoRa RX inRadioLibInterface. - Add
StatusLEDModulehandling to flashLED_LORAbriefly on each RX.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| variants/esp32s3/ELECROW-ThinkNode-M7/variant.cpp | Initializes the new LED_LORA output pin at boot. |
| src/modules/StatusLEDModule.h | Adds optional (LED_LORA-gated) observer + state for RX LED flash timing. |
| src/modules/StatusLEDModule.cpp | Subscribes to radio RX observable and implements timed RX flash logic. |
| src/mesh/RadioLibInterface.cpp | Notifies RX observable on packet receive and also toggles LED_LORA during TX. |
| src/mesh/RadioInterface.h | Declares a new static observable for LoRa RX events. |
| src/mesh/RadioInterface.cpp | Defines the new static observable instance. |
Contributor
⚡ Try this PR in the Web Flasher
Warning This is an automated, unreviewed CI test build. Back up your device configuration Supported boards built by this PR (22)
Build artifacts expire on 2026-07-13. Updated for |
jp-bennett
added a commit
that referenced
this pull request
Jun 13, 2026
* add optional LED_LORA to indicate LoRa TX * Briefly flash LED_LORA on packet RX --------- Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
oscgonfer
pushed a commit
that referenced
this pull request
Jun 14, 2026
* add optional LED_LORA to indicate LoRa TX * Briefly flash LED_LORA on packet RX --------- Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
raghumad
pushed a commit
to raghumad/mezulla-firmware
that referenced
this pull request
Jun 25, 2026
* add optional LED_LORA to indicate LoRa TX * Briefly flash LED_LORA on packet RX --------- Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested on the Elecrow M7, works as expected so far.