Actions: Update protobufs using the triggering branch#10612
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the update_protobufs.yml GitHub Actions workflow to select the protobufs submodule branch based on the triggering workflow branch, aiming to ensure develop runs use develop protobufs (and likewise for master).
Changes:
- Switch workflow branch checks from
github.reftogithub.ref_namefor clearer branch matching. - Update the protobufs submodule update step to run within
protobufs/and attempt to pull/checkout the triggering branch.
d2292f2 to
0d36bf0
Compare
0d36bf0 to
d435161
Compare
thebentern
approved these changes
Jun 3, 2026
d435161 to
7bf1530
Compare
jp-bennett
pushed a commit
that referenced
this pull request
Jun 8, 2026
Evil8it
pushed a commit
to Evil8it/ME4TACTNK
that referenced
this pull request
Jun 10, 2026
oscgonfer
pushed a commit
that referenced
this pull request
Jun 14, 2026
raghumad
pushed a commit
to raghumad/mezulla-firmware
that referenced
this pull request
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the workflow for updating protobuf submodules to better handle branch references and submodule updates. The main change is switching to use
github.ref_nameinstead ofgithub.refand improving how the protobuf submodule is updated. Now when the workflow is triggered indevelopbranch,developbranch protobufs will be used.Workflow improvements:
github.ref_namefor better clarity and reliability when checking if the workflow is running onmasterordevelopbranches.protobufs, uses an environment variable (GIT_BRANCH) to track the triggering branch, and replaces the previousgit submodule updatecommand with agit pullandgit checkoutto ensure the correct branch is checked out and up to date.