Debian: Correctly build without signing (for forks)#10605
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates the Debian source-package CI script to explicitly disable signing when no GPG key is provided, which improves reliability for fork builds where signing material is unavailable.
Changes:
- Add
-us -ucto the unsigneddebuildinvocation so source builds are explicitly unsigned whenGPG_KEY_IDis not set.
f30dd5c to
5334bcb
Compare
ianmcorvidae
approved these changes
Jun 2, 2026
ianmcorvidae
left a comment
Contributor
There was a problem hiding this comment.
This worked building locally following your instructions, so I think this is good!
Evil8it
pushed a commit
to Evil8it/ME4TACTNK
that referenced
this pull request
Jun 10, 2026
thebentern
pushed a commit
that referenced
this pull request
Jun 24, 2026
(cherry picked from commit 266c143)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a minor update to the Debian packaging script to clarify the behavior when building unsigned source packages. Specifically, it ensures that when no GPG key is provided, the build process explicitly disables signing.
debian/ci_pack_sdeb.sh: Added-us -ucflags to thedebuildcommand to explicitly disable signing when no GPG key is provided.