fix: first set pinMode, then write to pin#10520
Merged
Merged
Conversation
|
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes initialization ordering for two optional GPIO-controlled enable pins so the pin is configured as an output before being driven HIGH, avoiding ESP32 runtime errors like __digitalWrite(): IO xx is not set as GPIO.
Changes:
- In
SX126xInterface::init(), setpinMode(..., OUTPUT)beforedigitalWrite(..., HIGH)forSX126X_POWER_EN. - In
SX126xInterface::init(), setpinMode(..., OUTPUT)beforedigitalWrite(..., HIGH)forRF95_FAN_EN.
thebentern
pushed a commit
that referenced
this pull request
May 22, 2026
Evil8it
pushed a commit
to Evil8it/ME4TACTNK
that referenced
this pull request
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple fix of rarely used functions (EN pin of SX1262 and EN pin of fan), detected on my brand new LilyGo T-Beam 1W.
Before that fix there was a Critical Error 3.