Refactor position precision handling to honor explicit channel settings and prevent location leaks#10513
Merged
Merged
Conversation
…gs and prevent location leaks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a privacy bug where full-precision position could be shared even when a public channel had position sharing disabled, by changing position-precision selection to honor explicit per-channel module settings and otherwise “fail closed”.
Changes:
- Refactored
getPositionPrecisionForChannelto accept ameshtastic_Channeland return0when module settings are absent (removing the previous PRIMARY-channel default of32). - Updated the channel-index overload to delegate to the new channel-based helper.
- Added unit tests that verify explicit precision values are honored and that missing module settings disable position precision (regression coverage for #10509).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/mesh/PositionPrecision.h |
Adds channel-based overload declaration and required include for meshtastic_Channel. |
src/mesh/PositionPrecision.cpp |
Implements fail-closed precision selection and delegates index-based lookup to the new helper. |
test/test_position_precision/test_main.cpp |
Adds tests covering explicit precision, explicit disable (0), and fail-closed behavior when module settings are absent. |
thebentern
added a commit
that referenced
this pull request
May 22, 2026
…gs and prevent location leaks (#10513)
Evil8it
pushed a commit
to Evil8it/ME4TACTNK
that referenced
this pull request
Jun 10, 2026
…gs and prevent location leaks (meshtastic#10513)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10509