Refactor virtual keyboard cell height for layout consistency#10501
Merged
Conversation
Adjust keyboard cell height calculation for better layout consistency across different screen sizes.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts virtual keyboard rendering to improve layout consistency, particularly for SH1107 128x128 displays where the bottom row and key alignment were visibly off.
Changes:
- Updates default non-wide keyboard row height calculation to use a font-derived height.
- Applies consistent ceil-style horizontal text centering for non-action keys.
HarukiToreda
approved these changes
May 19, 2026
Xaositek
approved these changes
May 19, 2026
thebentern
added a commit
that referenced
this pull request
May 21, 2026
Adjust keyboard cell height calculation for better layout consistency across different screen sizes. Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
Evil8it
pushed a commit
to Evil8it/ME4TACTNK
that referenced
this pull request
Jun 10, 2026
Adjust keyboard cell height calculation for better layout consistency across different screen sizes. Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjust virtual keyboard cell height calculation for better layout consistency across different screen sizes.
This is the best fix I can do. Maybe if someone can do better it would be very helpful.
Fix #10446
before
after
🤝 Attestations