Enabled SX_LNA_EN by default#10469
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the M5Stack UnitC6L (ESP32-C6) variant bring-up to drive the PI4IO expander output for SX_LNA_EN high by default, aiming to improve RF receive performance / communication distance on that hardware.
Changes:
- Set PI4IO P5 (SX_LNA_EN) high during
c6l_init(). - Add an additional PI4IO OUT_SET read/modify/write step (and delays) to also set P6 (SX_ANT_SW).
| i2c_write_byte(PI4IO_M_ADDR, PI4IO_REG_OUT_SET, in_data); | ||
| vTaskDelay(10 / portTICK_PERIOD_MS); | ||
|
|
||
| i2c_read_byte(PI4IO_M_ADDR, PI4IO_REG_OUT_SET, &in_data); |
caveman99
left a comment
There was a problem hiding this comment.
If you set a new bit, you need to adapt the configuration registers too.
* Enabled SX_LNA_EN by default * Update I2C configuration for IO direction and pull settings --------- Co-authored-by: Thomas Göttgens <tgoettgens@gmail.com>
|
@RikerZhu And, I'm not sure who's right person to ask but to someone who's reading this: |
Что вошло из апстрима (40 коммитов): - Position precision security fix: утечка координат через PRIMARY канал (meshtastic#10509) - T-Echo-Card поддержка + OLED_TINY guard для компаса - ThinkNode M7, Station G3 варианты - SX_LNA_EN включён по умолчанию (meshtastic#10469) - WiFi TCP/HTTP fix при отсутствии USB serial (meshtastic#10460) - Rework clock renderer (70% max) - Обновлены protobufs → 59cb394 Конфликты разрешены: - UIRenderer.cpp: взята версия апстрима (OLED_TINY) вместо 2.8-ветки - PositionPrecision.{cpp,h}: взят upstream security fix (meshtastic#10509) - admin.pb.h, cardputer variant.cpp, test_position_precision: взят апстрим - protobufs submodule: обновлён до 59cb394 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
hi team, thank you for releasing 2.7.24 with this patch and others! |
* Enabled SX_LNA_EN by default * Update I2C configuration for IO direction and pull settings --------- Co-authored-by: Thomas Göttgens <tgoettgens@gmail.com>
Set PI4IO's P5 high by default, enabling SX_LNA_EN to resolving the insufficient communication distance issue in M5Stack Unit C6L.
Detailed some comments.