Skip to content

Make power status logging less chatty and track battery presence transitions#10453

Merged
thebentern merged 4 commits into
masterfrom
power-chatty
May 11, 2026
Merged

Make power status logging less chatty and track battery presence transitions#10453
thebentern merged 4 commits into
masterfrom
power-chatty

Conversation

@thebentern

Copy link
Copy Markdown
Contributor

No description provided.

@thebentern thebentern requested review from Copilot and jp-bennett May 11, 2026 12:39
@github-actions github-actions Bot added needs-review Needs human review enhancement New feature or request labels May 11, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reduces log noise from the power subsystem by gating periodic battery logs to only when a battery is actually present, and adds a one-time INFO log when battery presence transitions (detected/absent).

Changes:

  • Log battery presence transitions once (ignoring the initial OptUnknown state).
  • Replace the periodic battery debug log time check with Throttle::isWithinTimespanMs(...) and emit only when hasBattery == OptTrue.

@thebentern thebentern added the cleanup Code cleanup or refactor label May 11, 2026
@thebentern thebentern merged commit 7f51842 into master May 11, 2026
80 checks passed
advorzhak pushed a commit to advorzhak/meshtastic_firmware that referenced this pull request May 12, 2026
balya pushed a commit to balya/meshtastic-firmware that referenced this pull request May 14, 2026
@caveman99 caveman99 deleted the power-chatty branch June 7, 2026 20:55
Evil8it pushed a commit to Evil8it/ME4TACTNK that referenced this pull request Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup Code cleanup or refactor enhancement New feature or request needs-review Needs human review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants