Fix screen geometry update for SH1107 display#10444
Merged
Merged
Conversation
Added conditional block to update screen geometry for SH1107 128x128.
|
|
HarukiToreda
approved these changes
May 9, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes incorrect rendering on SH1107 128x128 OLEDs when the display type is selected via the device menu (config), by ensuring the runtime screen geometry is updated to match the 128x128 panel. This addresses issue #9751 where only a quarter of the screen was being used due to the geometry staying at the default 128x64.
Changes:
- When
config.display.oledis explicitly set (notOLED_AUTO), detectOLED_SH1107_128_128and setscreen_geometry = GEOMETRY_128_128. - Normalize the model value back to
OLED_SH1107after applying geometry, keeping the driver selection consistent with existing SH1107 handling.
thebentern
pushed a commit
that referenced
this pull request
May 9, 2026
Added conditional block to update screen geometry for SH1107 128x128.
balya
pushed a commit
to balya/meshtastic-firmware
that referenced
this pull request
May 14, 2026
Added conditional block to update screen geometry for SH1107 128x128.
Evil8it
pushed a commit
to Evil8it/ME4TACTNK
that referenced
this pull request
Jun 10, 2026
Added conditional block to update screen geometry for SH1107 128x128.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added conditional block to update screen geometry for SH1107 128x128.
before
after
Fix #9751
🤝 Attestations