Make heartbeat LED play nice with other LEDs#10423
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refines StatusLEDModule’s heartbeat LED behavior so it doesn’t interfere with other LED indications (notably charging/critical blink behavior), and ensures the dedicated heartbeat LED is explicitly turned off when heartbeat is disabled or suppressed.
Changes:
- Stop using
CHARGE_LED_stateas the heartbeat driver when a dedicatedLED_HEARTBEATpin exists. - Gate heartbeat blinking on non-charging/non-charged state and on not being in the fast-blink (critical) mode.
- Explicitly drive
LED_HEARTBEATlow/off when heartbeat is disabled or otherwise not allowed to blink.
| } | ||
| } | ||
|
|
||
| // If we want a LED to be dedicated to the simple hearbeat, we can use that instead of the charge LED |
Comment on lines
100
to
107
| @@ -117,6 +106,19 @@ int32_t StatusLEDModule::runOnce() | |||
| my_interval = 1; | |||
| } | |||
balya
pushed a commit
to balya/meshtastic-firmware
that referenced
this pull request
May 14, 2026
Evil8it
pushed a commit
to Evil8it/ME4TACTNK
that referenced
this pull request
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Existing change had some odd edge case behavior. Make LEDs dance together in harmony.