Skip to content

Enhance GPS search failure handling backoff logic#10404

Merged
thebentern merged 4 commits into
masterfrom
gps-backoff
May 7, 2026
Merged

Enhance GPS search failure handling backoff logic#10404
thebentern merged 4 commits into
masterfrom
gps-backoff

Conversation

@thebentern

Copy link
Copy Markdown
Contributor

No description provided.

@thebentern thebentern requested review from Copilot and jp-bennett May 6, 2026 20:35
@thebentern thebentern added the bugfix Pull request that fixes bugs label May 6, 2026
@github-actions github-actions Bot added needs-review Needs human review enhancement New feature or request labels May 6, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves GPS scheduling behavior when repeated GPS searches fail to obtain a fix, aiming to reduce power drain in hostile/indoor environments by backing off retry cadence and shortening subsequent search dwell time.

Changes:

  • Track consecutive GPS search failures and reset the counter on successful lock.
  • Add a failure-based backoff in msUntilNextSearch() to avoid retrying more frequently than the position broadcast interval (with a 1-hour cap).
  • Reduce maximum GPS search dwell time after a prior failure.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/gps/GPSUpdateScheduling.h Adds state to track consecutive GPS search failures.
src/gps/GPSUpdateScheduling.cpp Resets/increments failure counter; adds failure backoff and tighter dwell after failures.

Comment thread src/gps/GPSUpdateScheduling.cpp Outdated
thebentern and others added 2 commits May 6, 2026 18:58
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
A 160000 (gitlink) entry for .claude/worktrees/naughty-payne-60fdb7
pointing at f292359 was accidentally committed in 9db1578. The
path isn't a real submodule — it's a Claude Code agent worktree that
shouldn't be tracked.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@thebentern thebentern merged commit 33e2bb7 into master May 7, 2026
80 checks passed
@b8b8

b8b8 commented May 9, 2026

Copy link
Copy Markdown

Can this be updated so the double button click (of screenless devices) not only forces the standard position ping but ALSO forces a new lock if within the new cool down period. Basically you know youve been spelunking all day and as soon as you exit the cave, you want to manually force a new position lock. :)

@caveman99 caveman99 deleted the gps-backoff branch June 7, 2026 20:56
Evil8it pushed a commit to Evil8it/ME4TACTNK that referenced this pull request Jun 10, 2026
* Enhance GPS search failure handling backoff logic

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* Remove stray submodule gitlink for .claude worktree

A 160000 (gitlink) entry for .claude/worktrees/naughty-payne-60fdb7
pointing at f292359 was accidentally committed in 9db1578. The
path isn't a real submodule — it's a Claude Code agent worktree that
shouldn't be tracked.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes bugs enhancement New feature or request needs-review Needs human review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants