Fix GPS initialization logic for Portduino configuration#10395
Merged
Conversation
jp-bennett
approved these changes
May 5, 2026
Contributor
|
@jessm33 fix looks good! Would you mind retargeting this at master? |
Contributor
Author
It doesn't look like I can change that |
thebentern
pushed a commit
that referenced
this pull request
May 5, 2026
Co-authored-by: jessm33 <root@example.com>
Evil8it
pushed a commit
to Evil8it/ME4TACTNK
that referenced
this pull request
Jun 10, 2026
…10395) Co-authored-by: jessm33 <root@example.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #10206
rx and tx gpio's are used in numerous places as flags for gps presence so they must be set to non zero values for GPS to work, even if the hardware doesn't and can't use them. This code is ifdefed to only the Portduino architecture, so should have no effect on other platforms/variants.
🤝 Attestations