t5s3-epaper: Move variant.cpp -> extra_variants/variant.cpp ...again#10297
Merged
Conversation
Fixes issues with #includes inherited from `configuration.h` when building for pioarduino. Aligns t5s3_epaper with other variants like t_deck_pro. Co-authored-by: Copilot <copilot@github.com>
Contributor
|
this works |
mariotti
pushed a commit
to mariotti/firmware
that referenced
this pull request
May 6, 2026
…eshtastic#10297) Fixes issues with #includes inherited from `configuration.h` when building for pioarduino. Aligns t5s3_epaper with other variants like t_deck_pro. Co-authored-by: Copilot <copilot@github.com> Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#10241 was undone by #10286 so... fixing it again ✊
Fixes
t5s3-epaperissues with #includes inherited fromconfiguration.hwhen building for pioarduino (variants/is not included by the LDF there).Aligns t5s3_epaper with other variants like t_deck_pro.
This is intentionally targeting
developeven though it fixes an issue withpioarduinobuilds. Trying to keep that PR from getting too huge.