fix(inkhud): scale map applet markers with font size#10288
Merged
HarukiToreda merged 1 commit intoApr 25, 2026
Conversation
Marker boxes, the own-node bullseye, and the labeled-marker cross were all hardcoded in pixels (11px box, r=8 circle, 12px cross). On the T5S3 with a 12pt fontSmall (~17px line height) the hop-count digit overflowed its box entirely. Sizes now derive from fontSmall.lineHeight() so the applet renders correctly on both small (6pt) and large (12pt+) display variants. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
I checked the other targets like Heltec Wireless Paper and L1 Pro Eink, no regressions. Good to commit |
HarukiToreda
approved these changes
Apr 25, 2026
mariotti
pushed a commit
to mariotti/firmware
that referenced
this pull request
May 6, 2026
…tastic#10288) Marker boxes, the own-node bullseye, and the labeled-marker cross were all hardcoded in pixels (11px box, r=8 circle, 12px cross). On the T5S3 with a 12pt fontSmall (~17px line height) the hop-count digit overflowed its box entirely. Sizes now derive from fontSmall.lineHeight() so the applet renders correctly on both small (6pt) and large (12pt+) display variants. Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
MapApplet(used by the Positions applet) had all marker sizes hardcoded in pixels: an 11 px hop-count box, a radius-8 own-node bullseye, and a 12 px labeled-marker cross. On displays with a small font (6 pt, ~8 px line height) these looked fine. On the LilyGo T5-S3-ePaper-Pro, which uses a 12 ptfontSmall(~17 px line height), the hop-count digit overflowed its box entirely and all markers appeared as tiny specks on the 960×540 panel.All three sizes now derive from
fontSmall.lineHeight(), so the applet scales correctly across display variants without any per-variant tuning. Before / after screenshots attached.🤝 Attestations