Remove incorrect LED_STATE_ON definition for t-beam-s3#10280
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes a board-specific LED_STATE_ON override in the T-Beam Supreme (tbeam-s3-core) variant so the firmware falls back to the global default LED polarity, addressing reports of the blue LED being stuck on.
Changes:
- Removed
#define LED_STATE_ON 0from thetbeam-s3-corevariant to use the global default (LED_STATE_ON=1insrc/configuration.h). - Minor diff-only line normalization at the end of the file (no functional change).
Collaborator
Author
|
I suggest we merge and cherry-pick into master |
fifieldt
approved these changes
Apr 24, 2026
thebentern
pushed a commit
that referenced
this pull request
Apr 24, 2026
mariotti
pushed a commit
to mariotti/firmware
that referenced
this pull request
May 6, 2026
3 tasks
Evil8it
pushed a commit
to Evil8it/ME4TACTNK
that referenced
this pull request
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9912 and #10170