T-Echo-Card support by caveman99 · Pull Request #10267 · meshtastic/firmware

caveman99 · 2026-04-23T09:14:31Z

No description provided.

Copilot

Pull request overview

Adds initial firmware support for the LilyGo T-Echo-Card (nRF52840) variant, including OLED-specific layout handling and WS2812-based status/notification LEDs, while generalizing “tiny OLED” UI behavior across the graphics/BLE UI stack.

Changes:

Added a new t-echo-card nRF52840 variant (pins, early power sequencing, PlatformIO env).
Introduced OLED_TINY and migrated prior M5STACK_UNITC6L-specific tiny-screen UI conditionals to the new macro.
Added NeoPixel (WS2812) support for power/pairing status LEDs and the external notification LED, plus per-variant OLED geometry override and vertical page offset support.

Reviewed changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
variants/nrf52840/t-echo-card/variant.h	New board pinmap + WS2812 status roles + OLED geometry/y-offset defines + early power/GPS/buzzer pin definitions.
variants/nrf52840/t-echo-card/variant.cpp	New nRF52 variant pin map + `earlyInitVariant()` power-rail toggle and peripheral parking at boot.
variants/nrf52840/t-echo-card/platformio.ini	New `t-echo-card` build env (PRIVATE_HW, include path, build filter).
variants/esp32c6/m5stack_unitc6l/variant.h	Defines `OLED_TINY` for the existing tiny OLED board.
src/nimble/NimbleBluetooth.cpp	Uses `OLED_TINY` to simplify BLE pairing screen text for small displays.
src/modules/StatusLEDModule.h / .cpp	Adds optional WS2812 power/pairing pixels and updates run loop to drive them.
src/modules/ExternalNotificationModule.h / .cpp	Adds optional WS2812 notification pixel support and initializes it when enabled.
src/mesh/NodeDB.cpp	Enables External Notification module by default when WS2812 notification pin is present.
src/main.cpp	Adds `OLED_GEOMETRY_OVERRIDE` hook to override SSD1306 geometry per variant.
src/graphics/images.h	Uses `OLED_TINY` to select small vs normal icon assets.
src/graphics/draw/*.cpp, src/graphics/SharedUIDisplay.cpp, src/graphics/ScreenFonts.h, src/graphics/Screen.cpp	Migrates tiny-OLED conditionals to `OLED_TINY`; adds SSD1306 `setYOffset()` call when `OLED_Y_OFFSET_PAGES` is defined.
platformio.ini	Bumps the pinned `meshtastic/esp8266-oled-ssd1306` library revision.

Copilot

Pull request overview

Adds a new nRF52840 hardware variant (LilyGo T-Echo-Card) and generalizes “tiny OLED” UI/layout behavior (previously hard-coded to M5Stack Unit C6L) via an OLED_TINY feature flag, including support for vertically-offset micro OLED panels and WS2812-based status/notification LEDs.

Changes:

Add t-echo-card nRF52840 variant (pins, early power-rail reset sequencing, PlatformIO env).
Introduce OLED_TINY flag and migrate multiple UI/layout conditionals from M5STACK_UNITC6L to OLED_TINY.
Add WS2812 (NeoPixel) support for status/pairing/notification LEDs; add SSD1306 vertical page-offset support and bump the SSD1306 library dependency.

Reviewed changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
variants/nrf52840/t-echo-card/variant.h	New T-Echo-Card pin map, tiny OLED geometry + Y-offset, WS2812 status LED pin roles
variants/nrf52840/t-echo-card/variant.cpp	New variant pin map + `earlyInitVariant()` power-rail reset/parking sequence
variants/nrf52840/t-echo-card/platformio.ini	New `t-echo-card` PlatformIO environment
variants/esp32c6/m5stack_unitc6l/variant.h	Define `OLED_TINY` for UnitC6L
src/nimble/NimbleBluetooth.cpp	Use `OLED_TINY` to simplify pairing-code screen layout for tiny displays
src/modules/StatusLEDModule.h	Add optional NeoPixel-backed power/pairing LED members and defaults
src/modules/StatusLEDModule.cpp	Initialize NeoPixels; render power/pairing states to WS2812 pixels
src/modules/ExternalNotificationModule.h	Add optional NeoPixel-backed notification LED member and defaults
src/modules/ExternalNotificationModule.cpp	Drive notification WS2812 when toggling notification state
src/mesh/NodeDB.cpp	Enable ExternalNotification by default when WS2812 notification pin is present
src/main.cpp	Allow per-variant OLED geometry override via `OLED_GEOMETRY_OVERRIDE`
src/graphics/images.h	Switch to small icon asset when `OLED_TINY`
src/graphics/draw/UIRenderer.cpp	Replace UnitC6L-specific tiny-OLED logic with `OLED_TINY`
src/graphics/draw/NotificationRenderer.cpp	Replace UnitC6L-specific tiny-OLED logic with `OLED_TINY`
src/graphics/draw/NodeListRenderer.cpp	Replace UnitC6L-specific tiny-OLED logic with `OLED_TINY`
src/graphics/draw/MenuHandler.cpp	Use `OLED_TINY` to reduce clock menu options for tiny displays
src/graphics/draw/DebugRenderer.cpp	Use `OLED_TINY` to simplify debug screen content for tiny displays
src/graphics/SharedUIDisplay.cpp	Use `OLED_TINY` to adjust header rendering for tiny displays
src/graphics/ScreenFonts.h	Key font-size selection off `OLED_TINY`
src/graphics/Screen.cpp	Apply `OLED_Y_OFFSET_PAGES` via SSD1306Wire Y-offset; update several `OLED_TINY` conditionals
platformio.ini	Bump meshtastic SSD1306 library dependency revision

Xaositek

Looks solid! Testing on a C6L showed no regressions

Incorporates hardware-specific learnings from caveman99's Meshtastic T-Echo Card support PR (meshtastic/firmware#10267), cross-referenced against LilyGo's official t_echo_card_config.h pinmap. Battery (critical): - Add BATTERY_MEASUREMENT_CONTROL pin P0.31 — gates the resistive voltage divider feeding AIN0. Without toggling this pin, battery ADC reads are invalid (floating divider input). - TechoCardBoard::getBatteryVoltage() now drives P0.31 HIGH before SAADC read and LOW after to avoid parasitic drain. Display (critical): - Add OLED_DISPLAY_OFFSET = 24 for the SSD1315 72×40 panel. The physical display is mapped at GDDRAM pages 3–7 (rows 24–63); SETDISPLAYOFFSET and SETMULTIPLEX commands are sent after display.begin() in target.cpp to shift the visible window. Power rail (high priority): - RT9080 3V3 LDO now gets a clean HIGH→LOW→HIGH reset cycle with 100ms dwell in board.begin(), preventing brown-out when LoRa TX fires at +22 dBm after a soft reset.

Co-authored-by: vidplace7 <1779290+vidplace7@users.noreply.github.com>

…10480)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Co-authored-by: vidplace7 <1779290+vidplace7@users.noreply.github.com>

) * Fix position precision for direct sends * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Clarify zero position precision logging * Use const channel reference for position precision * Use C linkage for position precision test entrypoints --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Removed comment about setYOffset() patch requirement for OLED.

Removed debug logging statements from handleStatusUpdate method.

Removed comments and cleaned up the variant.h file for the LilyGo T-Echo-Card.

Removed notes about OLED dependencies and patching.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Co-authored-by: vidplace7 <1779290+vidplace7@users.noreply.github.com>

Co-authored-by: caveman99 <25002+caveman99@users.noreply.github.com>

caveman99 · 2026-05-19T05:22:57Z

@copilot resolve the merge conflicts in this pull request

Co-authored-by: caveman99 <25002+caveman99@users.noreply.github.com>

caveman99 · 2026-05-19T05:27:25Z

@copilot this PR was originally against develop. Rebase clean against master.

Copilot · 2026-05-19T05:28:42Z

@copilot resolve the merge conflicts in this pull request

Merged master into this branch and resolved the conflicts in commit 4f9d03b.

Copilot · 2026-05-19T05:31:54Z

@copilot this PR was originally against develop. Rebase clean against master.

I can’t safely complete that from this automation path because it requires rewriting published branch history (rebase + force-push), and this environment can only do regular pushes. If you want, I can proceed once force-push is enabled for this branch (or you can run the rebase/force-push and I’ll handle any follow-up conflicts).

# Conflicts: # src/graphics/draw/UIRenderer.cpp

github-actions Bot added needs-review Needs human review hardware-support Hardware related: new devices or modules, problems specific to hardware labels Apr 23, 2026

caveman99 requested review from Xaositek, Copilot and jp-bennett April 23, 2026 09:29

Copilot started reviewing on behalf of caveman99 April 23, 2026 09:29 View session

Copilot AI reviewed Apr 23, 2026

View reviewed changes

Comment thread variants/nrf52840/t-echo-card/variant.h Outdated

Comment thread variants/nrf52840/t-echo-card/platformio.ini Outdated

Comment thread src/graphics/Screen.cpp

caveman99 requested a review from Copilot April 23, 2026 09:51

Copilot started reviewing on behalf of caveman99 April 23, 2026 09:51 View session

Copilot AI reviewed Apr 23, 2026

View reviewed changes

Comment thread variants/nrf52840/t-echo-card/variant.h Outdated

Comment thread src/modules/StatusLEDModule.cpp Outdated

Xaositek approved these changes Apr 23, 2026

View reviewed changes

github-actions Bot and others added 12 commits May 14, 2026 06:43

Upgrade trunk (#10476)

fce419b

Co-authored-by: vidplace7 <1779290+vidplace7@users.noreply.github.com>

Add more support for small fonts in screen resolution determination (#…

1c05633

…10480)

Update libch341-spi-userspace digest to 2e5ff75 (#10485)

0570707

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Upgrade trunk (#10481)

502c5af

Co-authored-by: vidplace7 <1779290+vidplace7@users.noreply.github.com>

[WIP] T-Echo-Card support

4158be2

Remove obsolete comment regarding OLED Y offset

324653d

Removed comment about setYOffset() patch requirement for OLED.

Remove debug logs from handleStatusUpdate

33da3ec

Removed debug logging statements from handleStatusUpdate method.

Clean up comments in variant.h

86c518e

Removed comments and cleaned up the variant.h file for the LilyGo T-Echo-Card.

Clean up platformio.ini by removing obsolete comments

3f8290d

Removed notes about OLED dependencies and patching.

trunk me baby

0cc5ac9

Potential fix for pull request finding

5c88f1c

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Potential fix for pull request finding

454e2c3

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

caveman99 force-pushed the t-echo-card branch from c541008 to 454e2c3 Compare May 18, 2026 20:06

caveman99 marked this pull request as ready for review May 18, 2026 20:18

caveman99 mentioned this pull request May 18, 2026

Add T_ECHO_CARD identifier to mesh.proto meshtastic/protobufs#919

Merged

caveman99 changed the base branch from develop to master May 18, 2026 20:59

caveman99 and others added 4 commits May 18, 2026 23:00

Merge branch 'master' into t-echo-card

2449c9c

cherry pick backport fix for cardputer

6199faa

Upgrade trunk (#10493)

0148a89

Co-authored-by: vidplace7 <1779290+vidplace7@users.noreply.github.com>

Update protobufs (#10499)

af3739f

Co-authored-by: caveman99 <25002+caveman99@users.noreply.github.com>

Copilot started work on behalf of caveman99 May 19, 2026 05:23 View session

Merge origin/master into t-echo-card

4f9d03b

Co-authored-by: caveman99 <25002+caveman99@users.noreply.github.com>

Copilot finished work on behalf of caveman99 May 19, 2026 05:29

Copilot started work on behalf of caveman99 May 19, 2026 05:29 View session

Copilot finished work on behalf of caveman99 May 19, 2026 05:32

caveman99 changed the base branch from master to develop May 19, 2026 05:33

caveman99 added 2 commits May 19, 2026 07:47

Merge branch 'develop' into t-echo-card

1984e2a

Merge branch 'develop' into t-echo-card

2c5e748

caveman99 merged commit 1747e2d into develop May 19, 2026
26 of 67 checks passed

caveman99 added a commit that referenced this pull request May 19, 2026

T-Echo-Card support (#10267)

e2aa44e

# Conflicts: # src/graphics/draw/UIRenderer.cpp

caveman99 deleted the t-echo-card branch May 19, 2026 09:23

vidplace7 mentioned this pull request May 19, 2026

Add Lilygo T-Impulse-Plus #10497

Merged

8 tasks

Evil8it pushed a commit to Evil8it/ME4TACTNK that referenced this pull request Jun 10, 2026

T-Echo-Card support (meshtastic#10267)

0a522f9

# Conflicts: # src/graphics/draw/UIRenderer.cpp

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

T-Echo-Card support#10267

T-Echo-Card support#10267
caveman99 merged 20 commits into
developfrom
t-echo-card

caveman99 commented Apr 23, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Xaositek left a comment

Uh oh!

caveman99 commented May 19, 2026

Uh oh!

caveman99 commented May 19, 2026

Uh oh!

Copilot AI commented May 19, 2026

Uh oh!

Copilot AI commented May 19, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Uh oh!

Conversation

caveman99 commented Apr 23, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Xaositek left a comment

Choose a reason for hiding this comment

Uh oh!

caveman99 commented May 19, 2026

Uh oh!

caveman99 commented May 19, 2026

Uh oh!

Copilot AI commented May 19, 2026

Uh oh!

Copilot AI commented May 19, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants