Skip to content

Fix display method to use const qualifier for previousBuffer pointer#10146

Merged
thebentern merged 1 commit into
meshtastic:masterfrom
vidplace7:fix-einkparalleldisplay-cppcheck
Apr 13, 2026
Merged

Fix display method to use const qualifier for previousBuffer pointer#10146
thebentern merged 1 commit into
meshtastic:masterfrom
vidplace7:fix-einkparalleldisplay-cppcheck

Conversation

@vidplace7

@vidplace7 vidplace7 commented Apr 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Addresses cppcheck failures (GitHub Action)

src/graphics/EInkParallelDisplay.cpp:205: [low:style] Variable 'prev' can be declared as pointer to const [constVariablePointer]
variants/esp32s3/mini-epaper-s3/nicheGraphics.h:101: [low:style] Variable 'sa' can be declared as pointer to const [constVariablePointer]
variants/esp32s3/mini-epaper-s3/nicheGraphics.h:115: [low:style] Variable 'sa' can be declared as pointer to const [constVariablePointer]

Trying to clearup some of these check failures.

@vidplace7 vidplace7 requested a review from mverch67 April 13, 2026 00:02
@vidplace7 vidplace7 added the bugfix Pull request that fixes bugs label Apr 13, 2026
@vidplace7 vidplace7 changed the base branch from develop to master April 13, 2026 00:03
@vidplace7
Fix display method to use const qualifier for previousBuffer pointer
6a333ad 
Addresses cppcheck `src/graphics/EInkParallelDisplay.cpp:205: [low:style] Variable 'prev' can be declared as pointer to const [constVariablePointer]`
@vidplace7 vidplace7 force-pushed the fix-einkparalleldisplay-cppcheck branch from 7723b59 to 6a333ad Compare April 13, 2026 00:13
@vidplace7 vidplace7 requested a review from HarukiToreda April 13, 2026 00:15
@thebentern thebentern merged commit a1d6c6d into meshtastic:master Apr 13, 2026
79 checks passed
NomDeTom pushed a commit to NomDeTom/MeshtasticFirmware that referenced this pull request Apr 14, 2026
@vidplace7 @NomDeTom
Fix display method to use const qualifier for previousBuffer pointer (m…
db34e8e 
…eshtastic#10146)

Addresses cppcheck `src/graphics/EInkParallelDisplay.cpp:205: [low:style] Variable 'prev' can be declared as pointer to const [constVariablePointer]`
cvaldess pushed a commit to cvaldess/firmware that referenced this pull request Apr 15, 2026
@vidplace7 @cvaldess
Fix display method to use const qualifier for previousBuffer pointer (m…
3693959 
…eshtastic#10146)

Addresses cppcheck `src/graphics/EInkParallelDisplay.cpp:205: [low:style] Variable 'prev' can be declared as pointer to const [constVariablePointer]`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mverch67 mverch67 Awaiting requested review from mverch67
@HarukiToreda HarukiToreda Awaiting requested review from HarukiToreda

Assignees

No one assigned

Labels

bugfix Pull request that fixes bugs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vidplace7 @thebentern