Skip to content

Revert "Add include directive for mbedtls error handling in build flags"#10073

Merged
thebentern merged 1 commit into
meshtastic:developfrom
cpatulea:mbederror
Apr 11, 2026
Merged

Revert "Add include directive for mbedtls error handling in build flags"#10073
thebentern merged 1 commit into
meshtastic:developfrom
cpatulea:mbederror

Conversation

@cpatulea

@cpatulea cpatulea commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

This reverts commit 391928e.

Fixes compile error under pioarduino:

: fatal error: mbedtls/error.h: No such file or directory

🤝 Attestations

  • I have tested that my proposed changes behave as described.
  • I have tested that my proposed changes do not cause any obvious regressions on the following devices:
    • Heltec (Lora32) V3
    • LilyGo T-Deck
    • LilyGo T-Beam
    • RAK WisBlock 4631
    • Seeed Studio T-1000E tracker card
    • Other (please specify below)

@github-actions github-actions Bot added the bugfix Pull request that fixes bugs label Apr 3, 2026
@cpatulea cpatulea mentioned this pull request Apr 4, 2026
Merged
21 tasks
@cpatulea cpatulea marked this pull request as draft April 4, 2026 00:18
@cpatulea

cpatulea commented Apr 4, 2026

Copy link
Copy Markdown
Contributor Author

From build checks I now see the compile error which the original commit was intended to fix:

/pio/workspace/libdeps/heltec-ht62-esp32c3-sx1262/esp32_https_server/src/HTTPSConnection.cpp: In member function 'bool httpsserver::HTTPSConnection::setup(mbedtls_ssl_config*)':
/pio/workspace/libdeps/heltec-ht62-esp32c3-sx1262/esp32_https_server/src/HTTPSConnection.cpp:29:5: error: 'mbedtls_strerror' was not declared in this scope
     mbedtls_strerror(res, buf, sizeof(buf));
     ^~~~~~~~~~~~~~~~

Will work on a fix.

@mverch67

mverch67 commented Apr 4, 2026

Copy link
Copy Markdown
Collaborator

Will work on a fix.

I think the include "mbedtls/error.h" belongs to here:
https://github.com/meshtastic/esp32_https_server/blob/b78f12c86ea65c3ca08968840ff554ff7ed69b60/src/HTTPSConnection.cpp#L3

@cpatulea

cpatulea commented Apr 4, 2026

Copy link
Copy Markdown
Contributor Author

Yes you're right. That's the fix I'm working on.

@cpatulea

cpatulea commented Apr 4, 2026

Copy link
Copy Markdown
Contributor Author

meshtastic/esp32_https_server#11

@cpatulea

cpatulea commented Apr 9, 2026

Copy link
Copy Markdown
Contributor Author

esp32_https_server version has been bumped, but only in master. Waiting for that to be merged into develop, then I'll be able to re-open this PR.

@thebentern

thebentern commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

esp32_https_server version has been bumped, but only in master. Waiting for that to be merged into develop, then I'll be able to re-open this PR.

@cpatulea I have backmerged master into develop this morning

@mverch67 mverch67 marked this pull request as ready for review April 9, 2026 14:53
@cpatulea
Revert "Add include directive for mbedtls error handling in build flags"
1352dd7 
This reverts commit 391928e.

Since esp32_https_server commit e2c9f98, this is no longer necessary.

Also, the esp32-common.ini '-include mbedtls/error.h' causes a build error
under IDF v5 (meshtastic#9122 (comment)):

  <command-line>: fatal error: mbedtls/error.h: No such file or directory

so this change fixes that error.
@cpatulea

cpatulea commented Apr 10, 2026

Copy link
Copy Markdown
Contributor Author

@thebentern perfect, thank you. This PR is now ready for review.

@Dadud

Dadud commented Apr 10, 2026

Copy link
Copy Markdown

Pull Request

A fix has been submitted: PR #10127

Please review and merge if the changes look good. Thanks!

@garthvh garthvh requested a review from Copilot April 11, 2026 05:42
Copilot AI reviewed Apr 11, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Reverts a previously added global compiler -include mbedtls/error.h build flag for ESP32 targets to fix PlatformIO Arduino (pioarduino) builds that fail because that header is not available in that framework configuration.

Changes:

  • Removes the -include mbedtls/error.h directive from ESP32 common build_flags.

@thebentern thebentern merged commit 288d7a3 into meshtastic:develop Apr 11, 2026
96 of 276 checks passed
@cpatulea cpatulea deleted the mbederror branch April 11, 2026 17:41
mariotti pushed a commit to mariotti/firmware that referenced this pull request May 6, 2026
@cpatulea @mariotti
Revert "Add include directive for mbedtls error handling in build fla…
9f45d99 
…gs" (meshtastic#10073)

This reverts commit 391928e.

Since esp32_https_server commit e2c9f98, this is no longer necessary.

Also, the esp32-common.ini '-include mbedtls/error.h' causes a build error
under IDF v5 (meshtastic#9122 (comment)):

  <command-line>: fatal error: mbedtls/error.h: No such file or directory

so this change fixes that error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@mverch67 mverch67 mverch67 approved these changes

Assignees

No one assigned

Labels

bugfix Pull request that fixes bugs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cpatulea @mverch67 @thebentern @Dadud