Thinknode_m5 minor fixes#10049
Merged
Merged
Conversation
RCGV1
added a commit
to RCGV1/firmware-Fork
that referenced
this pull request
Apr 16, 2026
Upstream PR meshtastic#10049 (commit 98efb25, "Thinknode_m5 minor fixes") added PCA_LED_NOTIFICATION to the macro guard that auto-enables external_notification on boards with a buzzer, vibration motor, or LED. The baymesh branch was missing this addition, so PCA-LED boards did not get external_notification auto-enabled at first boot. Restore the upstream guard so PCA-LED boards behave like they do on upstream firmware. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct voltage multiplier, add PCA_LED_NOTIFICATION and ALT_BUTTON_WAKE