Set t5s3_epaper_inkhud to extra#10037
Merged
thebentern merged 1 commit intoMar 30, 2026
Merged
Conversation
t5s3_epaper_inkhud is incomplete (missing macros). Disable it for now. Also fixes the board_check evaluation so that `false` actually works.
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts CI/build selection so an incomplete ESP32-S3 InkHUD variant is excluded from normal CI builds, and fixes CI matrix generation so board_check = false is honored correctly.
Changes:
- Mark
t5s3_epaper_inkhudas anextra-level board and disable itsboard_check. - Fix
generate_ci_matrix.pyboolean parsing forboard_checkso"false"no longer evaluates asTrue.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| variants/esp32s3/t5s3_epaper/platformio.ini | Sets the InkHUD environment to board_level = extra and board_check = false to keep it out of standard CI. |
| bin/generate_ci_matrix.py | Corrects board_check parsing by comparing the string value to "true" rather than using Python bool() on a non-empty string. |
mverch67
approved these changes
Mar 30, 2026
skrashevich
pushed a commit
to skrashevich/meshtastic-firmware
that referenced
this pull request
Apr 4, 2026
t5s3_epaper_inkhud is incomplete (missing macros). Disable it for now. Also fixes the board_check evaluation so that `false` actually works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
t5s3_epaper_inkhudis incomplete (missing macros). Disable it for now.Also fixes the board_check evaluation in
generate_ci_matrix.pyso thatfalseactually works correctly.