Skip to content

Configure NFC pins as GPIO for older bootloaders#10016

Merged
thebentern merged 5 commits into
meshtastic:developfrom
NomDeTom:patch-2
Mar 30, 2026
Merged

Configure NFC pins as GPIO for older bootloaders#10016
thebentern merged 5 commits into
meshtastic:developfrom
NomDeTom:patch-2

Conversation

@NomDeTom

@NomDeTom NomDeTom commented Mar 26, 2026

Copy link
Copy Markdown
Collaborator

Should hopefully solve the issue in #9986

Definition courtesy of @Stary2001.

@porkcube could I impose on you to test the old and new bootloaders, please?

@sandos same, please: can you test it with old and new bootloader?

🤝 Attestations

  • I have tested that my proposed changes behave as described.
  • I have tested that my proposed changes do not cause any obvious regressions on the following devices:
    • Heltec (Lora32) V3
    • LilyGo T-Deck
    • LilyGo T-Beam
    • RAK WisBlock 4631
    • Seeed Studio T-1000E tracker card
    • Other (please specify below)

@github-actions github-actions Bot added needs-review Needs human review hardware-support Hardware related: new devices or modules, problems specific to hardware labels Mar 26, 2026
porkcube
porkcube reviewed Mar 28, 2026
View reviewed changes
Comment thread variants/nrf52840/seeed_xiao_nrf52840_kit/platformio.ini Outdated
@NomDeTom

NomDeTom commented Mar 28, 2026

Copy link
Copy Markdown
Collaborator Author

Can confirm that now that the formatting issues are fixed, it works, and also makes older versions of the fw work as well

@Stary2001 pointed this out:
https://github.com/adafruit/Adafruit_nRF52_Arduino/blob/master/cores/nRF5/nordic/nrfx/mdk/system_nrf52840.c#L148

Which apparently means it fixes the correct bit permanently, so hopefully this should be the end of it.

@porkcube

porkcube commented Mar 28, 2026

Copy link
Copy Markdown
Contributor

k, so far only confirmed xiao_ble_30db working on an actual xiao_ble - ikoka nano isn't finding radio nor is i2c or button working but more testing to do.

@porkcube

porkcube commented Mar 28, 2026

Copy link
Copy Markdown
Contributor

ok so far confirmed:
✅ xiao-ble (on a xiao-ble)
✅ seeed_xiao_nrf52840_e22_900m30s (ikoka nano - button nonop)
✅ seeed_xiao_nrf52840_e22_900m30s (ikoka stick - button nonop)
✅ seeed_xiao_nrf52840_btb (hey I made that one! button work)

@thebentern thebentern merged commit 283ccb8 into meshtastic:develop Mar 30, 2026
76 of 78 checks passed
thebentern added a commit that referenced this pull request Mar 30, 2026
@NomDeTom @thebentern
Configure NFC pins as GPIO for older bootloaders (#10016)
2955c12 
* Configure NFC pins as GPIO for older bootloaders

Should hopefully solve the issue in #9986

* Fix formatting of CONFIG_NFCT_PINS_AS_GPIOS flag in platformio.ini

---------

Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
skrashevich pushed a commit to skrashevich/meshtastic-firmware that referenced this pull request Apr 4, 2026
@NomDeTom @thebentern @skrashevich
Configure NFC pins as GPIO for older bootloaders (meshtastic#10016)
dd17031 
* Configure NFC pins as GPIO for older bootloaders

Should hopefully solve the issue in meshtastic#9986

* Fix formatting of CONFIG_NFCT_PINS_AS_GPIOS flag in platformio.ini

---------

Co-authored-by: Ben Meadors <benmmeadors@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@porkcube porkcube porkcube left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

hardware-support Hardware related: new devices or modules, problems specific to hardware needs-review Needs human review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NomDeTom @porkcube @thebentern