Update audits: tab alignment tracking issues + settings validation fixes#106
Merged
Conversation
- Changed canonical label from 'Delete / Remove' to 'Remove' (matches Android + firmware API) - Apple: meshtastic/Meshtastic-Apple#1841 - Android: meshtastic/Meshtastic-Android#5544
Reflects fixes merged May 2026: - BLE fixed_pin: now string input, preserves leading zeros, shows error indicator - LoRa spread_factor: now enforces 7–12 with error indicator - LoRa coding_rate: now enforces 5–8 with error indicator - Ambient lighting current: now enforces 0–31 with error indicator - Ambient lighting RGB: now enforces 0–255 with error indicators Ref: meshtastic/Meshtastic-Android#5477
thebentern
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds tracking issue numbers to the menu alignment audit and updates the settings validation matrix/reference doc with recent Android fixes.
Changes
Menu Alignment Audit (
standards/audits/menu-alignment-audit.md)§1 Bottom Navigation Tabs — Added tracking section with issue links:
§3 Node List Long-Press Context Menu — Added tracking section + changed canonical label Align Android menu orders to Apple or vis-à-vis. #6 from "Delete / Remove" to "Remove" (aligns with Android and firmware API):
Settings Validation Matrix (
standards/audits/settings-validation-matrix.md)Updated to reflect fixes from Android PR #5477:
fixed_pin: now string input, preserves leading zeros, shows error — ✅ Resolvedspread_factor: enforces 7–12 — ✅ Fixedcoding_rate: enforces 5–8 — ✅ Fixedcurrent: enforces 0–31 — ✅ FixedAndroid Validation Reference (
.github/docs/validation/settings-validation-android.md)Updated field descriptions to match current implementation post-PR #5477.