2.7.10 Working Changes by garthvh · Pull Request #1648 · meshtastic/Meshtastic-Apple

garthvh · 2026-04-02T18:25:56Z

What changed?

Danish Translation
Spanish Translation
TAK Server Improvements
Waypoint details improvements
Added missing view previews
Compass Styling Fixes
Node Last Updated fixes
Message Translation
CarPlay

Why did it change?

The debounce Task { ... } in the node list's onChange handler was not explicitly bound to the main actor. Since Router is @MainActor and selectedNode is a @State property, both must be accessed on the main actor. Adding @MainActor to the task closure ensures correct actor isolation and prevents a compile-time actor-isolation violation.

How is this tested?

Existing unit and UI tests cover node list navigation and routing behaviour.
Manual verification: node selection via deep-link/routing continues to work correctly with no actor isolation warnings.

Screenshots/Videos (when applicable)

Checklist

My code adheres to the project's coding and style guidelines.
I have conducted a self-review of my code.
I have commented my code, particularly in complex areas.
I have verified whether these changes require an update to existing documentation or if new documentation is needed, and created an issue in the docs repo if applicable.
I have tested the change to ensure that it works as intended.

* Add SwiftUI previews for simple helper views Agent-Logs-Url: https://github.com/meshtastic/Meshtastic-Apple/sessions/a2a43e8c-24fd-443a-8a98-13b678770edd Co-authored-by: garthvh <1795163+garthvh@users.noreply.github.com> * Add previews for action buttons, ChannelForm, MetricsColumnDetail, and DeviceOnboarding Agent-Logs-Url: https://github.com/meshtastic/Meshtastic-Apple/sessions/a2a43e8c-24fd-443a-8a98-13b678770edd Co-authored-by: garthvh <1795163+garthvh@users.noreply.github.com> * Add previews for config views, log views, AppLog, Firmware, AppData, and UserConfig Agent-Logs-Url: https://github.com/meshtastic/Meshtastic-Apple/sessions/a2a43e8c-24fd-443a-8a98-13b678770edd Co-authored-by: garthvh <1795163+garthvh@users.noreply.github.com> * Add preview for PositionConfig Agent-Logs-Url: https://github.com/meshtastic/Meshtastic-Apple/sessions/a2a43e8c-24fd-443a-8a98-13b678770edd Co-authored-by: garthvh <1795163+garthvh@users.noreply.github.com> * Fix formatting bugs in #Preview blocks: restore missing .environmentObject/.environment modifiers and add proper tab indentation Agent-Logs-Url: https://github.com/meshtastic/Meshtastic-Apple/sessions/7eeb7a54-7928-466f-8e39-b00d0012a09d Co-authored-by: garthvh <1795163+garthvh@users.noreply.github.com> * Linting fixes --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: garthvh <1795163+garthvh@users.noreply.github.com> Co-authored-by: Garth Vander Houwen <garthvh@yahoo.com>

CLAassistant · 2026-04-05T01:02:41Z

All committers have signed the CLA.

CLAassistant · 2026-04-05T01:02:41Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ garthvh
❌ Copilot
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

* Fixed some issues with waypoints and created a createdBy and lastUpdatedBy * Fix suggestions --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

Copilot

Pull request overview

This PR appears to prep the 2.7.10 release by updating translations, improving TAK-related UX/configuration, and enhancing developer ergonomics via extensive SwiftUI #Preview coverage (plus some waypoint metadata work).

Changes:

Add many SwiftUI #Preview blocks across Settings/Nodes/Helpers views to improve UI iteration.
Extend waypoint handling to track/display createdBy / lastUpdatedBy node metadata (Core Data + parsing + UI).
Update localization catalog content and bump project marketing version to 2.7.10 (plus some minor formatting/whitespace cleanup).

Reviewed changes

Copilot reviewed 82 out of 82 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
MeshtasticTests/RouterTests.swift	Minor formatting in settings route argument list.
MeshtasticTests/ConnectViewTests.swift	Minor formatting in test argument lists.
Meshtastic/Views/Settings/UserConfig.swift	Add SwiftUI `#Preview`.
Meshtastic/Views/Settings/UpdateIntervalPicker.swift	Add SwiftUI `#Preview`.
Meshtastic/Views/Settings/TAKServerConfig.swift	Remove stray blank lines near channel label section.
Meshtastic/Views/Settings/Logs/AppLogFilter.swift	Add SwiftUI `#Preview`.
Meshtastic/Views/Settings/GPSStatus.swift	Add SwiftUI `#Preview`.
Meshtastic/Views/Settings/Firmware.swift	Add SwiftUI `#Preview`.
Meshtastic/Views/Settings/Config/SecurityConfig.swift	Add SwiftUI `#Preview`.
Meshtastic/Views/Settings/Config/SaveConfigButton.swift	Add SwiftUI `#Preview`.
Meshtastic/Views/Settings/Config/PowerConfig.swift	Add SwiftUI `#Preview`.
Meshtastic/Views/Settings/Config/PositionConfig.swift	Add SwiftUI `#Preview`.
Meshtastic/Views/Settings/Config/NetworkConfig.swift	Add SwiftUI `#Preview`.
Meshtastic/Views/Settings/Config/Module/TelemetryConfig.swift	Add SwiftUI `#Preview`.
Meshtastic/Views/Settings/Config/Module/StoreForwardConfig.swift	Add SwiftUI `#Preview`.
Meshtastic/Views/Settings/Config/Module/SerialConfig.swift	Add SwiftUI `#Preview`.
Meshtastic/Views/Settings/Config/Module/RtttlConfig.swift	Add SwiftUI `#Preview`.
Meshtastic/Views/Settings/Config/Module/RangeTestConfig.swift	Add SwiftUI `#Preview`.
Meshtastic/Views/Settings/Config/Module/PaxCounterConfig.swift	Add SwiftUI `#Preview`.
Meshtastic/Views/Settings/Config/Module/MQTTConfig.swift	Add SwiftUI `#Preview`.
Meshtastic/Views/Settings/Config/Module/ExternalNotificationConfig.swift	Add SwiftUI `#Preview`.
Meshtastic/Views/Settings/Config/Module/DetectionSensorConfig.swift	Add SwiftUI `#Preview`.
Meshtastic/Views/Settings/Config/Module/CannedMessagesConfig.swift	Add SwiftUI `#Preview`.
Meshtastic/Views/Settings/Config/Module/AmbientLightingConfig.swift	Add SwiftUI `#Preview`.
Meshtastic/Views/Settings/Config/LoRaConfig.swift	Add SwiftUI `#Preview`.
Meshtastic/Views/Settings/Config/DisplayConfig.swift	Add SwiftUI `#Preview`.
Meshtastic/Views/Settings/Config/DeviceConfig.swift	Add SwiftUI `#Preview`.
Meshtastic/Views/Settings/Config/ConfigHeader.swift	Add SwiftUI `#Preview`.
Meshtastic/Views/Settings/Config/BluetoothConfig.swift	Add SwiftUI `#Preview`.
Meshtastic/Views/Settings/Channels/ChannelForm.swift	Add SwiftUI `#Preview`.
Meshtastic/Views/Settings/AppLog.swift	Add SwiftUI `#Preview`.
Meshtastic/Views/Settings/AppData.swift	Add SwiftUI `#Preview`.
Meshtastic/Views/Settings/About.swift	Add SwiftUI `#Preview`.
Meshtastic/Views/Onboarding/DeviceOnboarding.swift	Add SwiftUI `#Preview`.
Meshtastic/Views/Nodes/TraceRouteLog.swift	Add SwiftUI `#Preview`.
Meshtastic/Views/Nodes/PowerMetricsLog.swift	Add SwiftUI `#Preview`.
Meshtastic/Views/Nodes/PositionLog.swift	Add SwiftUI `#Preview`.
Meshtastic/Views/Nodes/PaxCounterLog.swift	Add SwiftUI `#Preview`.
Meshtastic/Views/Nodes/MeshMap.swift	Adjust waypoint sheets (padding + drag indicator).
Meshtastic/Views/Nodes/Helpers/NodeListFilter.swift	Add SwiftUI `#Preview`.
Meshtastic/Views/Nodes/Helpers/Metrics Columns/MetricsColumnDetail.swift	Add SwiftUI `#Preview`.
Meshtastic/Views/Nodes/Helpers/Map/WaypointForm.swift	Waypoint UI refactor + emoji input changes + created/updated-by display + node lookups.
Meshtastic/Views/Nodes/Helpers/Map/MapSettingsForm.swift	Add SwiftUI `#Preview`.
Meshtastic/Views/Nodes/Helpers/Map/MapContent/MeshMapContent.swift	Enable automatic annotation titles.
Meshtastic/Views/Nodes/Helpers/Map/MapContent/AnimatedNodePin.swift	Add SwiftUI `#Preview`.
Meshtastic/Views/Nodes/Helpers/Actions/TraceRouteButton.swift	Add SwiftUI `#Preview`.
Meshtastic/Views/Nodes/Helpers/Actions/NodeAlertsButton.swift	Add SwiftUI `#Preview`.
Meshtastic/Views/Nodes/Helpers/Actions/NavigateToButton.swift	Add SwiftUI `#Preview`.
Meshtastic/Views/Nodes/Helpers/Actions/IgnoreNodeButton.swift	Add SwiftUI `#Preview`.
Meshtastic/Views/Nodes/Helpers/Actions/FavoriteNodeButton.swift	Add SwiftUI `#Preview`.
Meshtastic/Views/Nodes/Helpers/Actions/ExchangeUserInfoButton.swift	Add SwiftUI `#Preview`.
Meshtastic/Views/Nodes/Helpers/Actions/ExchangePositionsButton.swift	Add SwiftUI `#Preview`.
Meshtastic/Views/Nodes/Helpers/Actions/DeleteNodeButton.swift	Add SwiftUI `#Preview`.
Meshtastic/Views/Nodes/Helpers/Actions/ClientHistoryButton.swift	Add SwiftUI `#Preview`.
Meshtastic/Views/Nodes/EnvironmentMetricsLog.swift	Add SwiftUI `#Preview`.
Meshtastic/Views/Nodes/DeviceMetricsLog.swift	Add SwiftUI `#Preview`.
Meshtastic/Views/Nodes/DetectionSensorLog.swift	Add SwiftUI `#Preview`.
Meshtastic/Views/Messages/TapbackInputView.swift	Add SwiftUI `#Preview` + remove trailing whitespace.
Meshtastic/Views/Messages/MessageContextMenuItems.swift	Remove extra blank lines.
Meshtastic/Views/Layouts/TraceRoute.swift	Add SwiftUI `#Preview`.
Meshtastic/Views/Helpers/Weather/LocalWeatherConditions.swift	Add SwiftUI `#Preview`.
Meshtastic/Views/Helpers/SecureInput.swift	Add SwiftUI `#Preview`.
Meshtastic/Views/Helpers/RXTXIndicatorView.swift	Add SwiftUI `#Preview`.
Meshtastic/Views/Helpers/RateLimitedButton.swift	Add SwiftUI `#Preview`.
Meshtastic/Views/Helpers/PowerMetrics.swift	Add SwiftUI `#Preview`.
Meshtastic/Views/Helpers/Messages/MessageTemplate.swift	Add SwiftUI `#Preview`.
Meshtastic/Views/Helpers/MeshtasticLogo.swift	Add SwiftUI `#Preview`.
Meshtastic/Views/Helpers/DateTimeText.swift	Add SwiftUI `#Preview`.
Meshtastic/Views/Helpers/CompassView.swift	Formatting cleanup in helper methods/layout markers.
Meshtastic/Views/Helpers/ChannelLock.swift	Add SwiftUI `#Preview`.
Meshtastic/Views/Helpers/BLESignalStrengthIndicator.swift	Add SwiftUI `#Preview`.
Meshtastic/Views/Helpers/BatteryCompact.swift	Add SwiftUI `#Preview`.
Meshtastic/Views/Connect/InvalidVersion.swift	Add SwiftUI `#Preview`.
Meshtastic/Views/Connect/Connect.swift	Minor formatting/whitespace cleanup in `DeviceConnectRow`.
Meshtastic/Meshtastic.xcdatamodeld/MeshtasticDataModelV 55.xcdatamodel/contents	Add `WaypointEntity.createdBy` and `WaypointEntity.lastUpdatedBy` attributes.
Meshtastic/Helpers/TAK/TAKConnection.swift	Remove trailing whitespace.
Meshtastic/Helpers/TAK/CoTXMLParser.swift	Collapse XMLParser delegate signatures to single-line formatting.
Meshtastic/Helpers/Mqtt/MqttClientProxyManager.swift	Remove trailing whitespace.
Meshtastic/Helpers/MeshPackets.swift	Populate new waypoint metadata fields when parsing waypoint packets.
Meshtastic/Extensions/CoreData/MessageEntityExtension.swift	Brace formatting cleanup.
Meshtastic.xcodeproj/project.pbxproj	Bump version to 2.7.10 and adjust some target build settings.
Localizable.xcstrings	Translation catalog updates + new/adjusted keys related to TAK/waypoint UI and punctuation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@published

… lookups (#1650) * feat: improve routing performance with split state, fetch batching, node cache, and debounce - Split Router's single @published navigationState into per-tab properties to reduce spurious re-renders across unrelated views - Add fetchBatchSize=50 and relationshipKeyPathsForPrefetching to node list - Optimize in-body array re-sort from 2 filter passes to single pass - Add in-memory node object ID cache on Router for O(1) lookups - Add fetchLimit=1 to getNodeInfo for early termination - Debounce rapid node selection changes with 100ms Task delay Agent-Logs-Url: https://github.com/meshtastic/Meshtastic-Apple/sessions/9bfe91f2-8ed7-4d2c-bb2e-4ed3dfd3a16c Co-authored-by: garthvh <1795163+garthvh@users.noreply.github.com> * Address code review: add debounce constant and thread-safety comment Agent-Logs-Url: https://github.com/meshtastic/Meshtastic-Apple/sessions/9bfe91f2-8ed7-4d2c-bb2e-4ed3dfd3a16c Co-authored-by: garthvh <1795163+garthvh@users.noreply.github.com> * Migrate test project to Swift Testing and add connect view and router tests (#1643) * Migrate to Swift Testing and add connect view tests - Convert RouterTests.swift from XCTest to Swift Testing (@suite, @test, #expect, #require) - Create ConnectViewTests.swift with tests for connect view child types: - Device struct (creation, signal strength, RSSI, description, codable) - TransportType enum (cases, raw values, codable) - ConnectionState enum (equality, codable) - BLESignalStrength enum (raw values, init) - TransportStatus enum (equality) - NavigationState (defaults, tabs, sub-states) - InvalidVersion view (creation with versions) - ConnectedDevice view (connected/disconnected/MQTT states) - CircleText view (default/custom sizes, emoji) - BatteryCompact view (levels, nil, charging, plugged in) - SignalStrengthIndicator view (dimensions, strength levels) - Update Xcode project to include new test file Agent-Logs-Url: https://github.com/meshtastic/Meshtastic-Apple/sessions/d7bb7a89-2105-4fcb-96bc-7ec794467c74 Co-authored-by: garthvh <1795163+garthvh@users.noreply.github.com> * Fix signal strength test boundary conditions The getSignalStrength() method uses NSNumber.compare(.orderedDescending), which is a strict greater-than check. Fix the boundary test cases: - RSSI -65 is .normal (not .strong), since -65 is not > -65 - RSSI -85 is .weak (not .normal), since -85 is not > -85 - Add -64 → .strong and -84 → .normal as adjacent boundary tests Agent-Logs-Url: https://github.com/meshtastic/Meshtastic-Apple/sessions/4fcbc01e-cbea-4d11-b2c0-e923c6730d69 Co-authored-by: garthvh <1795163+garthvh@users.noreply.github.com> * Improve and complete router tests with comprehensive coverage Added tests for: - Custom initial state - Invalid scheme / unknown path handling (state unchanged) - navigateToNodeDetail public method - Messages edge cases: channelId only, userNum only, messageId only, non-numeric params - Nodes with non-numeric nodenum - Map with both nodenum+waypointId (nodeId priority), non-numeric params - Parameterized settings test covering all 31 SettingsNavigationState cases - State transitions: consecutive routes, invalid scheme preserves existing state Agent-Logs-Url: https://github.com/meshtastic/Meshtastic-Apple/sessions/f69b7352-21aa-494c-8864-31fc0f4b21b8 Co-authored-by: garthvh <1795163+garthvh@users.noreply.github.com> * Localizable update * Merge translations file --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: garthvh <1795163+garthvh@users.noreply.github.com> Co-authored-by: Garth Vander Houwen <garthvh@yahoo.com> * Fix merge conflicts in PR #1614 (Spanish translations) (#1644) * 20% of strings translated to spanish * add more translations * add rest of translations * small fixes --------- Co-authored-by: Joel Pérez Izquierdo <joelperez91@gmail.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: garthvh <1795163+garthvh@users.noreply.github.com> * fix typo in hop limit option description (#1631) O hop -> 0 hop Co-authored-by: garthvh <1795163+garthvh@users.noreply.github.com> * Tak server improvements (#1603) * added read only mode cot to meshtastic parsing and warning to not enable on pub channel * better icons * fully fixed markers * telemetry support * Update Meshtastic/Helpers/TAK/TAKServerManager.swift Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fixes * fixes * Resolve merge conflicts for PR #1603 (TAK server improvements) (#1645) * Delete Messages fix * Bump version to 2.7.9 * Bump widgets version * TAK Server channel index picker Create a settings picker for the TAK Server's channel index. This allows users to specify TAK traffic to use the non-primary channel to help reduce channel congestion. * Changed capitalization from 'environment' to 'Environment' for section header. (#1591) * Add Danish (da) translations — resolves merge conflicts from PR #1609 (#1612) * Initial plan * Add Danish (da) translations from PR #1609 Resolves merge conflicts from PR #1609 by adding Danish translations to the Localizable.xcstrings file. The PR adds Danish translation strings throughout the app while preserving all existing translations for other languages. Co-authored-by: garthvh <1795163+garthvh@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: garthvh <1795163+garthvh@users.noreply.github.com> * Migrate test project to Swift Testing and add connect view and router tests (#1643) * Migrate to Swift Testing and add connect view tests - Convert RouterTests.swift from XCTest to Swift Testing (@suite, @test, #expect, #require) - Create ConnectViewTests.swift with tests for connect view child types: - Device struct (creation, signal strength, RSSI, description, codable) - TransportType enum (cases, raw values, codable) - ConnectionState enum (equality, codable) - BLESignalStrength enum (raw values, init) - TransportStatus enum (equality) - NavigationState (defaults, tabs, sub-states) - InvalidVersion view (creation with versions) - ConnectedDevice view (connected/disconnected/MQTT states) - CircleText view (default/custom sizes, emoji) - BatteryCompact view (levels, nil, charging, plugged in) - SignalStrengthIndicator view (dimensions, strength levels) - Update Xcode project to include new test file Agent-Logs-Url: https://github.com/meshtastic/Meshtastic-Apple/sessions/d7bb7a89-2105-4fcb-96bc-7ec794467c74 Co-authored-by: garthvh <1795163+garthvh@users.noreply.github.com> * Fix signal strength test boundary conditions The getSignalStrength() method uses NSNumber.compare(.orderedDescending), which is a strict greater-than check. Fix the boundary test cases: - RSSI -65 is .normal (not .strong), since -65 is not > -65 - RSSI -85 is .weak (not .normal), since -85 is not > -85 - Add -64 → .strong and -84 → .normal as adjacent boundary tests Agent-Logs-Url: https://github.com/meshtastic/Meshtastic-Apple/sessions/4fcbc01e-cbea-4d11-b2c0-e923c6730d69 Co-authored-by: garthvh <1795163+garthvh@users.noreply.github.com> * Improve and complete router tests with comprehensive coverage Added tests for: - Custom initial state - Invalid scheme / unknown path handling (state unchanged) - navigateToNodeDetail public method - Messages edge cases: channelId only, userNum only, messageId only, non-numeric params - Nodes with non-numeric nodenum - Map with both nodenum+waypointId (nodeId priority), non-numeric params - Parameterized settings test covering all 31 SettingsNavigationState cases - State transitions: consecutive routes, invalid scheme preserves existing state Agent-Logs-Url: https://github.com/meshtastic/Meshtastic-Apple/sessions/f69b7352-21aa-494c-8864-31fc0f4b21b8 Co-authored-by: garthvh <1795163+garthvh@users.noreply.github.com> * Localizable update * Merge translations file --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: garthvh <1795163+garthvh@users.noreply.github.com> Co-authored-by: Garth Vander Houwen <garthvh@yahoo.com> * Fix merge conflicts in PR #1614 (Spanish translations) (#1644) * 20% of strings translated to spanish * add more translations * add rest of translations * small fixes --------- Co-authored-by: Joel Pérez Izquierdo <joelperez91@gmail.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: garthvh <1795163+garthvh@users.noreply.github.com> * fix typo in hop limit option description (#1631) O hop -> 0 hop --------- Co-authored-by: Jake-B <jake-b@users.noreply.github.com> Co-authored-by: Garth Vander Houwen <garthvh@yahoo.com> Co-authored-by: niccellular <79813408+niccellular@users.noreply.github.com> Co-authored-by: Austin Hargis <25471876+austinhargis@users.noreply.github.com> Co-authored-by: Ben Meadors <benmmeadors@gmail.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: garthvh <1795163+garthvh@users.noreply.github.com> Co-authored-by: Joel Pérez Izquierdo <joelperez91@gmail.com> Co-authored-by: axunes <axunes@axunes.net> * Fix merge conflicts * Merge main into tak-server-improvements to resolve PR #1603 conflicts (#1646) * Delete Messages fix * Bump version to 2.7.9 * Bump widgets version * TAK Server channel index picker Create a settings picker for the TAK Server's channel index. This allows users to specify TAK traffic to use the non-primary channel to help reduce channel congestion. * Changed capitalization from 'environment' to 'Environment' for section header. (#1591) * Add Danish (da) translations — resolves merge conflicts from PR #1609 (#1612) * Initial plan * Add Danish (da) translations from PR #1609 Resolves merge conflicts from PR #1609 by adding Danish translations to the Localizable.xcstrings file. The PR adds Danish translation strings throughout the app while preserving all existing translations for other languages. Co-authored-by: garthvh <1795163+garthvh@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: garthvh <1795163+garthvh@users.noreply.github.com> * Migrate test project to Swift Testing and add connect view and router tests (#1643) * Migrate to Swift Testing and add connect view tests - Convert RouterTests.swift from XCTest to Swift Testing (@suite, @test, #expect, #require) - Create ConnectViewTests.swift with tests for connect view child types: - Device struct (creation, signal strength, RSSI, description, codable) - TransportType enum (cases, raw values, codable) - ConnectionState enum (equality, codable) - BLESignalStrength enum (raw values, init) - TransportStatus enum (equality) - NavigationState (defaults, tabs, sub-states) - InvalidVersion view (creation with versions) - ConnectedDevice view (connected/disconnected/MQTT states) - CircleText view (default/custom sizes, emoji) - BatteryCompact view (levels, nil, charging, plugged in) - SignalStrengthIndicator view (dimensions, strength levels) - Update Xcode project to include new test file Agent-Logs-Url: https://github.com/meshtastic/Meshtastic-Apple/sessions/d7bb7a89-2105-4fcb-96bc-7ec794467c74 Co-authored-by: garthvh <1795163+garthvh@users.noreply.github.com> * Fix signal strength test boundary conditions The getSignalStrength() method uses NSNumber.compare(.orderedDescending), which is a strict greater-than check. Fix the boundary test cases: - RSSI -65 is .normal (not .strong), since -65 is not > -65 - RSSI -85 is .weak (not .normal), since -85 is not > -85 - Add -64 → .strong and -84 → .normal as adjacent boundary tests Agent-Logs-Url: https://github.com/meshtastic/Meshtastic-Apple/sessions/4fcbc01e-cbea-4d11-b2c0-e923c6730d69 Co-authored-by: garthvh <1795163+garthvh@users.noreply.github.com> * Improve and complete router tests with comprehensive coverage Added tests for: - Custom initial state - Invalid scheme / unknown path handling (state unchanged) - navigateToNodeDetail public method - Messages edge cases: channelId only, userNum only, messageId only, non-numeric params - Nodes with non-numeric nodenum - Map with both nodenum+waypointId (nodeId priority), non-numeric params - Parameterized settings test covering all 31 SettingsNavigationState cases - State transitions: consecutive routes, invalid scheme preserves existing state Agent-Logs-Url: https://github.com/meshtastic/Meshtastic-Apple/sessions/f69b7352-21aa-494c-8864-31fc0f4b21b8 Co-authored-by: garthvh <1795163+garthvh@users.noreply.github.com> * Localizable update * Merge translations file --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: garthvh <1795163+garthvh@users.noreply.github.com> Co-authored-by: Garth Vander Houwen <garthvh@yahoo.com> * Fix merge conflicts in PR #1614 (Spanish translations) (#1644) * 20% of strings translated to spanish * add more translations * add rest of translations * small fixes --------- Co-authored-by: Joel Pérez Izquierdo <joelperez91@gmail.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: garthvh <1795163+garthvh@users.noreply.github.com> * fix typo in hop limit option description (#1631) O hop -> 0 hop --------- Co-authored-by: Jake-B <jake-b@users.noreply.github.com> Co-authored-by: Garth Vander Houwen <garthvh@yahoo.com> Co-authored-by: niccellular <79813408+niccellular@users.noreply.github.com> Co-authored-by: Austin Hargis <25471876+austinhargis@users.noreply.github.com> Co-authored-by: Ben Meadors <benmmeadors@gmail.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: garthvh <1795163+garthvh@users.noreply.github.com> Co-authored-by: Joel Pérez Izquierdo <joelperez91@gmail.com> Co-authored-by: axunes <axunes@axunes.net> * Merge main into tak-server-improvements to resolve PR #1603 conflicts (#1647) * Delete Messages fix * Bump version to 2.7.9 * Bump widgets version * TAK Server channel index picker Create a settings picker for the TAK Server's channel index. This allows users to specify TAK traffic to use the non-primary channel to help reduce channel congestion. * Changed capitalization from 'environment' to 'Environment' for section header. (#1591) * Add Danish (da) translations — resolves merge conflicts from PR #1609 (#1612) * Initial plan * Add Danish (da) translations from PR #1609 Resolves merge conflicts from PR #1609 by adding Danish translations to the Localizable.xcstrings file. The PR adds Danish translation strings throughout the app while preserving all existing translations for other languages. Co-authored-by: garthvh <1795163+garthvh@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: garthvh <1795163+garthvh@users.noreply.github.com> * Migrate test project to Swift Testing and add connect view and router tests (#1643) * Migrate to Swift Testing and add connect view tests - Convert RouterTests.swift from XCTest to Swift Testing (@suite, @test, #expect, #require) - Create ConnectViewTests.swift with tests for connect view child types: - Device struct (creation, signal strength, RSSI, description, codable) - TransportType enum (cases, raw values, codable) - ConnectionState enum (equality, codable) - BLESignalStrength enum (raw values, init) - TransportStatus enum (equality) - NavigationState (defaults, tabs, sub-states) - InvalidVersion view (creation with versions) - ConnectedDevice view (connected/disconnected/MQTT states) - CircleText view (default/custom sizes, emoji) - BatteryCompact view (levels, nil, charging, plugged in) - SignalStrengthIndicator view (dimensions, strength levels) - Update Xcode project to include new test file Agent-Logs-Url: https://github.com/meshtastic/Meshtastic-Apple/sessions/d7bb7a89-2105-4fcb-96bc-7ec794467c74 Co-authored-by: garthvh <1795163+garthvh@users.noreply.github.com> * Fix signal strength test boundary conditions The getSignalStrength() method uses NSNumber.compare(.orderedDescending), which is a strict greater-than check. Fix the boundary test cases: - RSSI -65 is .normal (not .strong), since -65 is not > -65 - RSSI -85 is .weak (not .normal), since -85 is not > -85 - Add -64 → .strong and -84 → .normal as adjacent boundary tests Agent-Logs-Url: https://github.com/meshtastic/Meshtastic-Apple/sessions/4fcbc01e-cbea-4d11-b2c0-e923c6730d69 Co-authored-by: garthvh <1795163+garthvh@users.noreply.github.com> * Improve and complete router tests with comprehensive coverage Added tests for: - Custom initial state - Invalid scheme / unknown path handling (state unchanged) - navigateToNodeDetail public method - Messages edge cases: channelId only, userNum only, messageId only, non-numeric params - Nodes with non-numeric nodenum - Map with both nodenum+waypointId (nodeId priority), non-numeric params - Parameterized settings test covering all 31 SettingsNavigationState cases - State transitions: consecutive routes, invalid scheme preserves existing state Agent-Logs-Url: https://github.com/meshtastic/Meshtastic-Apple/sessions/f69b7352-21aa-494c-8864-31fc0f4b21b8 Co-authored-by: garthvh <1795163+garthvh@users.noreply.github.com> * Localizable update * Merge translations file --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: garthvh <1795163+garthvh@users.noreply.github.com> Co-authored-by: Garth Vander Houwen <garthvh@yahoo.com> * Fix merge conflicts in PR #1614 (Spanish translations) (#1644) * 20% of strings translated to spanish * add more translations * add rest of translations * small fixes --------- Co-authored-by: Joel Pérez Izquierdo <joelperez91@gmail.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: garthvh <1795163+garthvh@users.noreply.github.com> * fix typo in hop limit option description (#1631) O hop -> 0 hop --------- Co-authored-by: Jake-B <jake-b@users.noreply.github.com> Co-authored-by: Garth Vander Houwen <garthvh@yahoo.com> Co-authored-by: niccellular <79813408+niccellular@users.noreply.github.com> Co-authored-by: Austin Hargis <25471876+austinhargis@users.noreply.github.com> Co-authored-by: Ben Meadors <benmmeadors@gmail.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: garthvh <1795163+garthvh@users.noreply.github.com> Co-authored-by: Joel Pérez Izquierdo <joelperez91@gmail.com> Co-authored-by: axunes <axunes@axunes.net> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: Jake-B <jake-b@users.noreply.github.com> Co-authored-by: Garth Vander Houwen <garthvh@yahoo.com> Co-authored-by: niccellular <79813408+niccellular@users.noreply.github.com> Co-authored-by: Austin Hargis <25471876+austinhargis@users.noreply.github.com> Co-authored-by: Ben Meadors <benmmeadors@gmail.com> Co-authored-by: garthvh <1795163+garthvh@users.noreply.github.com> Co-authored-by: Joel Pérez Izquierdo <joelperez91@gmail.com> Co-authored-by: axunes <axunes@axunes.net> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: garthvh <1795163+garthvh@users.noreply.github.com> Co-authored-by: Garth Vander Houwen <garthvh@yahoo.com> Co-authored-by: Joel Pérez Izquierdo <joelperez91@gmail.com> Co-authored-by: axunes <axunes@axunes.net> Co-authored-by: Benjamin Faershtein <119711889+RCGV1@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Jake-B <jake-b@users.noreply.github.com> Co-authored-by: niccellular <79813408+niccellular@users.noreply.github.com> Co-authored-by: Austin Hargis <25471876+austinhargis@users.noreply.github.com> Co-authored-by: Ben Meadors <benmmeadors@gmail.com>

* Add map legend feature (issue #924) Implement a map legend overlay accessible from both the mesh map and node detail map views. The legend explains all visual map elements including: - Online/offline node markers with pulsing animation - Detection sensor nodes - Waypoints - Position precision circles - Position history points and heading arrows - Route start/end markers and route lines - Convex hull mesh coverage outline A new "map" button is added to the floating control buttons on both map views, opening the legend as a sheet. Agent-Logs-Url: https://github.com/meshtastic/Meshtastic-Apple/sessions/23f75e1e-549b-46a1-84c9-fb0a6375dcd9 Co-authored-by: garthvh <1795163+garthvh@users.noreply.github.com> * Improve legend descriptions for online/offline nodes Agent-Logs-Url: https://github.com/meshtastic/Meshtastic-Apple/sessions/23f75e1e-549b-46a1-84c9-fb0a6375dcd9 Co-authored-by: garthvh <1795163+garthvh@users.noreply.github.com> * map button glass and cleanup * Update Meshtastic/Views/Nodes/Helpers/Map/MapLegend.swift Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update incorect online timeframe * Update Meshtastic/Views/Nodes/MeshMap.swift Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update Meshtastic/Views/Nodes/Helpers/Map/NodeMapSwiftUI.swift Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * translation file --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: garthvh <1795163+garthvh@users.noreply.github.com> Co-authored-by: Garth Vander Houwen <garthvh@yahoo.com> Co-authored-by: Garth Vander Houwen <garth@meshtastic.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 98 out of 98 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 98 out of 98 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Removed 'createdBy' and 'lastUpdatedBy' attributes from WaypointEntity.

* Add deep link documentation to README (#1655) Agent-Logs-Url: https://github.com/meshtastic/Meshtastic-Apple/sessions/df28c94e-7e3d-44fc-8264-6ae1b875fb23 Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: garthvh <1795163+garthvh@users.noreply.github.com> * message translation core data version to match 2.7.10 --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: garthvh <1795163+garthvh@users.noreply.github.com>

* NFC Tag contact * Add Tools.swift to Xcode project file - fix missing file reference causing build failure Agent-Logs-Url: https://github.com/meshtastic/Meshtastic-Apple/sessions/e3299e28-9ec0-4a23-98bc-5fc032750b4a Co-authored-by: garthvh <1795163+garthvh@users.noreply.github.com> * Apply reviewer feedback: Catalyst guard, NDEF entitlement, nil guard, localized string, capacity check, preview fix Agent-Logs-Url: https://github.com/meshtastic/Meshtastic-Apple/sessions/b86f9b74-5ee1-4144-87e5-3e4b6479ac44 Co-authored-by: garthvh <1795163+garthvh@users.noreply.github.com> * Log tag NDEF capacity on query for debugging Agent-Logs-Url: https://github.com/meshtastic/Meshtastic-Apple/sessions/b86f9b74-5ee1-4144-87e5-3e4b6479ac44 Co-authored-by: garthvh <1795163+garthvh@users.noreply.github.com> * Fix formatting error * Linting fixes --------- Co-authored-by: Benjamin Faershtein <119711889+RCGV1@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: garthvh <1795163+garthvh@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 196 out of 198 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

garthvh · 2026-04-21T18:34:14Z

@copilot resolve the merge conflicts in this pull request

Co-authored-by: garthvh <1795163+garthvh@users.noreply.github.com>

Copilot · 2026-04-21T18:36:08Z

@copilot resolve the merge conflicts in this pull request

Done in commit 5de04d15. Merged origin/main and resolved the README.md conflict by keeping the CarPlay section from our branch alongside the upstream changes.

…ssage directions Agent-Logs-Url: https://github.com/meshtastic/Meshtastic-Apple/sessions/8d6ac69d-c18f-47f5-a264-c0652fe97608 Co-authored-by: garthvh <1795163+garthvh@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 195 out of 197 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…nd outgoing DMs Agent-Logs-Url: https://github.com/meshtastic/Meshtastic-Apple/sessions/fce7f5ef-090e-4033-93dc-592ed5d4ccbe Co-authored-by: garthvh <1795163+garthvh@users.noreply.github.com>

Agent-Logs-Url: https://github.com/meshtastic/Meshtastic-Apple/sessions/4028b211-825e-4c0a-8913-864c60626ad7 Co-authored-by: garthvh <1795163+garthvh@users.noreply.github.com>

garthvh and others added 2 commits April 2, 2026 11:15

Update translations file, bump version

f5afce2

Show which node created a waypoint and which last updated by (#1496)

04ef427

* Fixed some issues with waypoints and created a createdBy and lastUpdatedBy * Fix suggestions --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

garthvh requested a review from Copilot April 5, 2026 01:11

Copilot started reviewing on behalf of garthvh April 5, 2026 01:12 View session

Copilot AI reviewed Apr 5, 2026

View reviewed changes

Copilot AI and others added 6 commits April 4, 2026 18:51

Try and fix ios 17 memory leak

d6b8c59

Fix emojionlytextfield regression by @RCGV1

4b847b6

Handle nil emoji

8978fce

Compass fixes

21794d0

garthvh requested a review from Copilot April 5, 2026 21:43

Copilot started reviewing on behalf of garthvh April 5, 2026 21:44 View session

Copilot AI reviewed Apr 5, 2026

View reviewed changes

garthvh added 2 commits April 5, 2026 14:57

fix compass labels

7e4fb0a

Fix compass ugly

d493a24

garthvh requested a review from Copilot April 5, 2026 23:49

Copilot started reviewing on behalf of garthvh April 5, 2026 23:50 View session

Copilot AI reviewed Apr 5, 2026

View reviewed changes

Comment thread Meshtastic.xcodeproj/project.pbxproj Outdated

Comment thread Meshtastic/Views/Nodes/Helpers/Map/MapLegend.swift

Comment thread Meshtastic/Views/Nodes/Helpers/Map/MapLegend.swift

garthvh and others added 5 commits April 5, 2026 17:14

Update Meshtastic.xcodeproj/project.pbxproj

1f9b438

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Remove unnecessary attributes from WaypointEntity

6794603

Removed 'createdBy' and 'lastUpdatedBy' attributes from WaypointEntity.

Properly add new waypoint fields

ff7fbda

garthvh requested a review from Copilot April 6, 2026 17:49

Copilot started reviewing on behalf of garthvh April 6, 2026 17:50 View session

Copilot started work on behalf of garthvh April 6, 2026 17:54 View session

garthvh added 2 commits April 20, 2026 11:05

Fix regressions from merged pull request updates in 2.7.10

92b0cad

Fix last updated edge case for node info data

91731b8

garthvh requested a review from Copilot April 21, 2026 16:28

Copilot started reviewing on behalf of garthvh April 21, 2026 16:29 View session

Copilot AI reviewed Apr 21, 2026

View reviewed changes

Comment thread Meshtastic/Intents/SearchForMessagesIntentHandler.swift

Comment thread Meshtastic/CarPlay/CarPlayIntentDonation.swift

Comment thread MeshtasticProtobufs/Sources/meshtastic/telemetry.pb.swift

Comment thread Meshtastic/Info.plist

Copilot started work on behalf of garthvh April 21, 2026 18:34 View session

Merge origin/main: keep CarPlay section, resolve README conflict

5de04d1

Co-authored-by: garthvh <1795163+garthvh@users.noreply.github.com>

Copilot finished work on behalf of garthvh April 21, 2026 18:37

Copilot started work on behalf of garthvh April 21, 2026 21:51 View session

Copilot finished work on behalf of garthvh April 21, 2026 21:52

garthvh requested a review from Copilot April 21, 2026 23:17

Copilot started reviewing on behalf of garthvh April 21, 2026 23:18 View session

Copilot started work on behalf of garthvh April 21, 2026 23:19 View session

Fix DM predicate in SearchForMessagesIntentHandler to include both me…

afef028

…ssage directions Agent-Logs-Url: https://github.com/meshtastic/Meshtastic-Apple/sessions/8d6ac69d-c18f-47f5-a264-c0652fe97608 Co-authored-by: garthvh <1795163+garthvh@users.noreply.github.com>

Copilot finished work on behalf of garthvh April 21, 2026 23:22

Copilot AI reviewed Apr 21, 2026

View reviewed changes

Copilot started work on behalf of garthvh April 21, 2026 23:24 View session

garthvh and others added 2 commits April 21, 2026 16:24

Update .github/copilot-instructions.md

b621c63

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Fix conversationIdentifier to use remote node num for both incoming a…

768e41a

…nd outgoing DMs Agent-Logs-Url: https://github.com/meshtastic/Meshtastic-Apple/sessions/fce7f5ef-090e-4033-93dc-592ed5d4ccbe Co-authored-by: garthvh <1795163+garthvh@users.noreply.github.com>

Copilot finished work on behalf of garthvh April 21, 2026 23:26

Copilot started work on behalf of garthvh April 21, 2026 23:26 View session

Copilot finished work on behalf of garthvh April 21, 2026 23:28

Copilot started work on behalf of garthvh April 21, 2026 23:28 View session

garthvh and others added 2 commits April 21, 2026 16:28

Fix regreassions

beb7c60

Fix RSSI formatting to use String(format:) for consistency with SNR

9776086

Agent-Logs-Url: https://github.com/meshtastic/Meshtastic-Apple/sessions/4028b211-825e-4c0a-8913-864c60626ad7 Co-authored-by: garthvh <1795163+garthvh@users.noreply.github.com>

Copilot finished work on behalf of garthvh April 21, 2026 23:31

garthvh merged commit bfb25c6 into main Apr 21, 2026
1 check was pending

garthvh deleted the 2.7.10 branch April 21, 2026 23:37

Uh oh!

Uh oh!

Conversation

garthvh commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changed?

Why did it change?

How is this tested?

Screenshots/Videos (when applicable)

Checklist

Uh oh!

CLAassistant commented Apr 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CLAassistant commented Apr 5, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

garthvh commented Apr 21, 2026

Uh oh!

Copilot AI commented Apr 21, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

garthvh commented Apr 2, 2026 •

edited

Loading

CLAassistant commented Apr 5, 2026 •

edited

Loading