feat(db): Add sender-based message filtering#4477
Merged
Merged
Conversation
This commit introduces the ability to filter messages based on the sender node. When a node is ignored, all existing and future messages from that node will be marked as filtered in the database. Changes include: - A new DAO method `updateFilteredBySender` to bulk-update the `filtered` status of packets from a specific sender. - The `PacketRepository` now exposes a function to utilize this new DAO method. - The `shouldFilterMessage` logic in `MeshDataHandler` now immediately filters messages from ignored nodes. - Toggling the "ignore" status for a node now triggers an update to filter or un-filter all associated messages in the database. - Unit tests for `MeshDataHandler` have been added to verify new and existing functionality. Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4477 +/- ##
========================================
+ Coverage 8.56% 9.22% +0.65%
========================================
Files 427 427
Lines 14326 14332 +6
Branches 2383 2385 +2
========================================
+ Hits 1227 1322 +95
+ Misses 12877 12757 -120
- Partials 222 253 +31 ☔ View full report in Codecov by Sentry. |
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces the ability to filter messages based on the sender node. When a node is ignored, all existing and future messages from that node will be marked as filtered in the database.
Changes include:
updateFilteredBySenderto bulk-update thefilteredstatus of packets from a specific sender.PacketRepositorynow exposes a function to utilize this new DAO method.shouldFilterMessagelogic inMeshDataHandlernow immediately filters messages from ignored nodes.MeshDataHandlerhave been added to verify new and existing functionality.resolves #4466