build: Lower JDK to 17 and minSdk to 21#4369
Merged
Merged
Conversation
This commit reverts the project's Java Development Kit (JDK) requirement from version 21 back to 17. This change improves build compatibility for developers and consumers of the project's libraries who may be using older development environments. The minimum Android API level (minSdk) for the `core:api`, `core:model`, and `core:proto` modules has also been lowered to 21. This increases compatibility with consumer applications like ATAK and other plugins. Key changes include: - Updating GitHub Actions workflows (`reusable-android-build.yml`, `reusable-lint.yml`) to use JDK 17. - Modifying Gradle build logic (`build-logic/`) and toolchain configurations to target JDK 17. - Adjusting the `jitpack.yml` configuration to use `openjdk17`. - Lowering `minSdk` to 21 in core library modules. - Updating developer documentation (`copilot-instructions.md`) to reflect the new JDK 17 requirement. Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
d32b677 to
9f415fd
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4369 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 3 3
Lines 28 28
Branches 8 8
=====================================
Misses 28 28 ☔ View full report in Codecov by Sentry. |
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jan 30, 2026
Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
Secrets are now passed down to reusable workflows using `secrets: inherit` instead of being explicitly listed. This simplifies the `pull-request.yml` and `merge-queue.yml` files. Additionally, the `reusable-lint.yml` workflow has been updated to accept a `GRADLE_CACHE_URL` secret to configure the Gradle cache. Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit reverts the project's Java Development Kit (JDK) requirement from version 21 back to 17. This change improves build compatibility for developers and consumers of the project's libraries who may be using older development environments.
The minimum Android API level (minSdk) for the
core:api,core:model, andcore:protomodules has also been lowered to 21. This increases compatibility with consumer applications like ATAK and other plugins.Key changes include:
reusable-android-build.yml,reusable-lint.yml) to use JDK 17.build-logic/) and toolchain configurations to target JDK 17.jitpack.ymlconfiguration to useopenjdk17.minSdkto 21 in core library modules.copilot-instructions.md) to reflect the new JDK 17 requirement.