refactor(firmware): Inject dispatcher into BleOtaTransport#4339
Merged
Conversation
This commit introduces dependency injection for the `CoroutineDispatcher` in `BleOtaTransport`. This change improves testability by allowing a `TestDispatcher` to be provided during unit tests, ensuring more reliable and deterministic test execution. Key changes: - `BleOtaTransport` now accepts a `CoroutineDispatcher` in its constructor, defaulting to `Dispatchers.Default`. - The internal `transportScope` is now created using the injected dispatcher. - `BleOtaTransportTest` and `BleOtaTransportMtuTest` are updated to inject an `UnconfinedTestDispatcher`, and `runTest` is configured to use it. - The `notificationFlow` in `BleOtaTransportTest` is updated with extra buffer capacity to prevent a race condition in the test setup. Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4339 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 3 3
Lines 28 28
Branches 8 8
=====================================
Misses 28 28 ☔ View full report in Codecov by Sentry. |
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jan 27, 2026
Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces dependency injection for the
CoroutineDispatcherinBleOtaTransport. This change improves testability by allowing aTestDispatcherto be provided during unit tests, ensuring more reliable and deterministic test execution.Key changes:
BleOtaTransportnow accepts aCoroutineDispatcherin its constructor, defaulting toDispatchers.Default.transportScopeis now created using the injected dispatcher.BleOtaTransportTestandBleOtaTransportMtuTestare updated to inject anUnconfinedTestDispatcher, andrunTestis configured to use it.notificationFlowinBleOtaTransportTestis updated with extra buffer capacity to prevent a race condition in the test setup.