refactor: Use device address to manage service lifecycle#4251
Merged
Conversation
This commit updates `MeshService` to use the current device address (`getDeviceAddress`) instead of the bonded device address (`getBondedDeviceAddress`) to determine if it should run in the foreground. This ensures the service correctly stops itself when no device is actively selected, improving lifecycle management. Logging has also been added to clarify when the service is stopped for this reason and to note when the task is removed. Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4251 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 3 3
Lines 23 23
Branches 7 7
=====================================
Misses 23 23 ☔ View full report in Codecov by Sentry. |
jamesarich
added a commit
to jamesarich/Meshtastic-Android
that referenced
this pull request
Jan 21, 2026
…4251) Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates
MeshServiceto use the current device address (getDeviceAddress) instead of the bonded device address (getBondedDeviceAddress) to determine if it should run in the foreground.This ensures the service correctly stops itself when no device is actively selected, improving lifecycle management. Logging has also been added to clarify when the service is stopped for this reason and to note when the task is removed.