Codecov Report

❌ Patch coverage is 0% with 101 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.53%. Comparing base (d60e84f) to head (ff08250).
⚠️ Report is 3 commits behind head on main.

@@           Coverage Diff            @@
##            main   #3846      +/-   ##
========================================
- Coverage   0.53%   0.53%   -0.01%     
========================================
  Files        386     390       +4     
  Lines      22631   22846     +215     
  Branches    2842    2889      +47     
========================================
  Hits         122     122              
- Misses     22488   22703     +215     
  Partials      21      21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

It's not clear to the user if the app will proceed with the update despite wrong bootloader.

E.g. the update failed for me at 0%, but I have no idea what was the reason.

It's not clear to the user if the app will proceed with the update despite wrong bootloader.

E.g. the update failed for me at 0%, but I have no idea what was the reason.

There's currently no way to determine the available bootloader and whether or not it will be successful, hence the warning.

You clicked the button that says "I know what I'm doing" - if you don't.. you shouldn't.

It's not clear to the user if the app will proceed with the update despite wrong bootloader.

E.g. the update failed for me at 0%, but I have no idea what was the reason.

Thats normally due to improper bootloader. What device do you have?

The BLE library we use doesn't expose much as to "why" it failed or allow us to see what version of bootloader the device has before kicking off unfortunately.

Cc @jamesarich edit you beat me to it lol

rak4631.

Ok then.
In that case, simple clarification string (in the red dialog box) "...and update man fail." would make a difference.

rak4631.

Ok then.
In that case, simple clarification string (in the red dialog box) "...and update man fail." would make a difference.

Thats literally what this PR did, there are multiple warnings saying the update can fail?

It doesn't hint that it will fail quietly.
What you just told me is nowhere in the warning.

It doesn't hint that it will fail quietly. What you just told me is nowhere in the warning.

There's a big red box with a warning that you may potentially need an update for ota to work (that includes a link to more information), and an interstitial "I know what I'm doing." dialog with a friendly Chirpy. There's plenty of hand holding and warning.

If you click past all those without checking/understanding the impact - that's kinda on you.

The real issue at hand is that the process didn't time out with an error when the operation couldn't proceed - see #3846 .