feat(bluetooth): Request location permission for BLE scan pre S#3724
Merged
Conversation
…droid versions On Android versions prior to SDK 31 (Android S), `ACCESS_FINE_LOCATION` permission is required to perform a Bluetooth LE scan. This commit adds a conditional check for the device's SDK version. - If the SDK version is S (31) or higher, it requests `BLUETOOTH_SCAN` and `BLUETOOTH_CONNECT`. - If the SDK version is lower, it requests `ACCESS_FINE_LOCATION`. This ensures the app has the necessary permissions to scan for BLE devices across different Android versions. Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3724 +/- ##
========================================
- Coverage 0.56% 0.56% -0.01%
========================================
Files 381 381
Lines 21695 21697 +2
Branches 2677 2678 +1
========================================
Hits 122 122
- Misses 21552 21554 +2
Partials 21 21 ☔ View full report in Codecov by Sentry. |
mdecourcy
pushed a commit
to mdecourcy/Meshtastic-Android
that referenced
this pull request
Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Android versions prior to SDK 31 (Android S),
ACCESS_FINE_LOCATIONpermission is required to perform a Bluetooth LE scan. This commit adds a conditional check for the device's SDK version.BLUETOOTH_SCANandBLUETOOTH_CONNECT.ACCESS_FINE_LOCATION.This ensures the app has the necessary permissions to scan for BLE devices across different Android versions.