fix(bluetooth): Check for permissions before accessing bonded devices#3720
Merged
Conversation
resolves #3719 This addresses a potential crash by ensuring Bluetooth permissions are checked before attempting to access bonded peripherals. Specifically, `getBondedAppPeripherals` now verifies `hasBluetoothPermission()` before retrieving the list of bonded devices. Additionally, a toast notification has been added to inform the user when necessary permissions are missing for a Bluetooth scan. Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3720 +/- ##
========================================
- Coverage 0.56% 0.56% -0.01%
========================================
Files 380 380
Lines 21647 21649 +2
Branches 2654 2653 -1
========================================
Hits 122 122
- Misses 21504 21506 +2
Partials 21 21 ☔ View full report in Codecov by Sentry. |
mdecourcy
pushed a commit
to mdecourcy/Meshtastic-Android
that referenced
this pull request
Nov 19, 2025
…meshtastic#3720) Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #3719
This addresses a potential crash by ensuring Bluetooth permissions are checked before attempting to access bonded peripherals.
Specifically,
getBondedAppPeripheralsnow verifieshasBluetoothPermission()before retrieving the list of bonded devices.Additionally, a toast notification has been added to inform the user when necessary permissions are missing for a Bluetooth scan.