feat #3642: Add infrastructure to the list of filters.#3716
Merged
jamesarich merged 2 commits intoNov 17, 2025
Conversation
Then refactor, because we reached detekt's limit.
6 tasks
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3716 +/- ##
========================================
- Coverage 0.56% 0.56% -0.01%
========================================
Files 378 380 +2
Lines 21621 21647 +26
Branches 2662 2654 -8
========================================
Hits 122 122
- Misses 21478 21504 +26
Partials 21 21 ☔ View full report in Codecov by Sentry. |
jamesarich
reviewed
Nov 16, 2025
jamesarich
requested changes
Nov 16, 2025
jamesarich
left a comment
Collaborator
There was a problem hiding this comment.
Make it opt-in (exclude not include) pls
Collaborator
Author
|
I agree with your reasoning. but I hate that we have both versions already in the app. |
jamesarich
approved these changes
Nov 17, 2025
Collaborator
heard - filters maybe could use an overall audit anyway |
mdecourcy
pushed a commit
to mdecourcy/Meshtastic-Android
that referenced
this pull request
Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3642
Adds an 'include infrastructure' filter for nodes.
Then refactor, because we reached detekt's limit.