refactor(coroutines): Use SupervisorJobs#3714
Merged
Merged
Conversation
…o scopes This commit refactors coroutine scope management to improve robustness and efficiency. In `RadioInterfaceService`, the `serviceScope` now uses a `SupervisorJob` instead of a `Job`. This prevents the failure of one child coroutine from canceling the entire scope, which is critical when the service starts a new interface. In `DataStoreModule`, a single `CoroutineScope` with a `SupervisorJob` is now provided as a singleton (`@DataStoreScope`). This shared scope is injected into all DataStore providers, eliminating the creation of a new scope for each DataStore instance. This reduces resource overhead and centralizes scope management for data persistence operations. Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3714 +/- ##
========================================
- Coverage 0.56% 0.56% -0.01%
========================================
Files 378 378
Lines 21621 21622 +1
Branches 2662 2662
========================================
Hits 122 122
- Misses 21478 21479 +1
Partials 21 21 ☔ View full report in Codecov by Sentry. |
mdecourcy
pushed a commit
to mdecourcy/Meshtastic-Android
that referenced
this pull request
Nov 19, 2025
Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactors DataStore and Radio coroutine scope management to improve robustness and efficiency.
In
RadioInterfaceService, theserviceScopenow uses aSupervisorJobinstead of aJob. This prevents the failure of one child coroutine from canceling the entire scope, which is critical when the service starts a new interface.In
DataStoreModule, a singleCoroutineScopewith aSupervisorJobis now provided as a singleton (@DataStoreScope). This shared scope is injected into all DataStore providers, eliminating the creation of a new scope for each DataStore instance. This reduces resource overhead and centralizes scope management for data persistence operations.