fix: address backfill issue on tcp connections; add logging#3676
Merged
jamesarich merged 6 commits intoNov 14, 2025
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3676 +/- ##
========================================
+ Coverage 0.51% 0.56% +0.05%
========================================
Files 377 377
Lines 21298 21449 +151
Branches 2580 2622 +42
========================================
+ Hits 109 122 +13
- Misses 21169 21307 +138
Partials 20 20 ☔ View full report in Codecov by Sentry. |
2fde6b9 to
e2bd4e6
Compare
a99fb61 to
3668f93
Compare
3668f93 to
24729ba
Compare
jamesarich
requested changes
Nov 14, 2025
jamesarich
left a comment
Collaborator
There was a problem hiding this comment.
looks like the rebase munged a few of the things implemented in #3691
|
|
||
| PayloadVariantCase.LOG_RECORD -> { proto: MeshProtos.FromRadio -> handleLogRecord(proto.logRecord) } | ||
| PayloadVariantCase.LOG_RECORD -> { proto: MeshProtos.FromRadio -> handleLogReord(proto.logRecord) } | ||
|
|
Collaborator
There was a problem hiding this comment.
oop looks like you undid my typo fix... and some of the logging I had added in #3691 for the bt connection, mind giving it another pass?
Contributor
Author
There was a problem hiding this comment.
My bad yeah i was in rebase hell for a bit there. On it
Collaborator
There was a problem hiding this comment.
When it gets too bad, cherrypicking the other way onto a new branch is often easier
DaneEvans
reviewed
Nov 14, 2025
jamesarich
requested changes
Nov 14, 2025
…htastic#3691) Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
jamesarich
approved these changes
Nov 14, 2025
mdecourcy
added a commit
to mdecourcy/Meshtastic-Android
that referenced
this pull request
Nov 19, 2025
…ic#3676) Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com> Co-authored-by: James Rich <2199651+jamesarich@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures the Android client always asks the radio for its buffered text messages after a disconnect/reconnect and captures the responses. We now persist the last StoreForward replay marker per device, issue a CLIENT_HISTORY request (and restart the RX collector) as soon as any transport returns to CONNECTED, and ship focused debug logs/tests. That brings Wi‑Fi/TCP reconnects back in line with BLE/2.7.5, so queued messages are delivered again.
To close #3672
big thanks to @dblaber / corruptedstack on discord for helping verify! My heltec just came in and I have also verified.