ESM: delegate gps management to LocationProvider#820
Conversation
|
this one is also important for fixing failing t-echo build: https://files.brazio.org/meshcore/nightly/report.txt |
|
Great, this looks cleaner. |
Hi @Quency-D, really can't blame you because, there was (and it's still not totally fixed) a mess here. In the end we owe you one because it forced me to act ;) I'm seeing some interest in #778 and think this could be handed to location provider too ... I've let a message there |
| digitalWrite(_pin_en, PIN_GPS_EN_ACTIVE); | ||
| } | ||
| if (_pin_reset != -1) { | ||
| digitalWrite(_pin_reset, !GPS_RESET_FORCE); |
There was a problem hiding this comment.
Just wondering if the begin() also needs to do the same reset logic as before... with the delay(10) etc?
There was a problem hiding this comment.
I'll be awk most of the day ...
But the idea here was power on through begin() and reset() to reset (I even wait 100ms here which is a lot ...)
There was a problem hiding this comment.
I rethought about it and called reset after begin to force reset (and keep exact same behaviour of ESM as it has been used for months ;) )
should be ok now
ESM: delegate gps management to LocationProvider
There was duplicate code (and duplicate symbols) that led to lots of confusion
Tried to use gps init routines from LocationProvider in ESM, instead of having the same code (with different symbol names)