Set OFFLINE_QUEUE_SIZE=256 for missing WiFi companion environments#1833
Merged
Merged
Conversation
robekl
added a commit
to robekl/MeshCore
that referenced
this pull request
Mar 23, 2026
Reimplements meshcore-dev/MeshCore PR meshcore-dev#1833 on top of 467959c for the 1.14.1 maintenance branch. References: PR: meshcore-dev#1833 Companion radio source: https://github.com/meshcore-dev/MeshCore/tree/467959cc3bfc884e5f3425caac89453a450151b6/examples/companion_radio Rationale: Two WiFi companion environments were still inheriting the default OFFLINE_QUEUE_SIZE of 16 while comparable companion targets already override that queue to 256. This is a targeted configuration-only fix with no code-path changes. Reapplying it here keeps the release branch aligned with the established companion sizing used by other supported WiFi boards and reduces the chance of avoidable queue exhaustion under bursty traffic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds -D OFFLINE_QUEUE_SIZE=256 to WiFi companion environments that were missing this parameter:
I did successful builds for all three targets.