fix: raise ValueError when deleting nonexistent memory#4455
Merged
kartik-mem0 merged 2 commits intomainfrom Mar 20, 2026
Merged
fix: raise ValueError when deleting nonexistent memory#4455kartik-mem0 merged 2 commits intomainfrom
kartik-mem0 merged 2 commits intomainfrom
Conversation
utkarsh240799
approved these changes
Mar 20, 2026
2 tasks
jamebobob
pushed a commit
to jamebobob/mem0-vigil-recall
that referenced
this pull request
Mar 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When vector_store.get() returns None (memory ID not found), the code accesses .payload on None, causing an unhelpful AttributeError: 'NoneType' object has no attribute 'payload'.
This affects delete(), update(), and the session ID update handler in add() — all 3 code paths hit the same crash. Confirmed that all 6 vector store implementations (Qdrant, MongoDB, PGVector,
FAISS, Pinecone, Supabase) can return None from get().
This fix adds null checks after every vector_store.get() call that accesses .payload in both Memory and AsyncMemory:
Fixes #3849
Type of change
How Has This Been Tested?
Added 4 new tests:
pytest tests/test_memory.py -v
21/21 passed
Bug reproduction verified — without the fix, both delete() and update() crash with AttributeError: 'NoneType' object has no attribute 'payload'. With the fix, they raise a clear ValueError.
Checklist:
Maintainer Checklist
memory.delete()fails withAttributeError: 'NoneType' object has no attribute 'payload'when using Qdrant #3849