fix: handle truncated code blocks in removeCodeBlocks function#4421
Merged
whysosaket merged 2 commits intomainfrom Mar 19, 2026
Merged
fix: handle truncated code blocks in removeCodeBlocks function#4421whysosaket merged 2 commits intomainfrom
whysosaket merged 2 commits intomainfrom
Conversation
whysosaket
approved these changes
Mar 19, 2026
This was referenced Mar 19, 2026
jamebobob
pushed a commit
to jamebobob/mem0-vigil-recall
that referenced
this pull request
Mar 29, 2026
wuhonglei
pushed a commit
to wuhonglei/mem0
that referenced
this pull request
Apr 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
removeCodeBlocksfails to strip markdown fences from truncated LLM responses. When an LLM returns JSON wrapped in```jsonthat gets truncated (no closing fence), the regex doesn't matchand raw text with backticks is passed to
JSON.parse, causing a SyntaxError. This silently drops all extracted memories.Fixed by making the closing fence optional in the regex:
(?:```|$)matches either the closing fence or end-of-string.Fixes #4401
Type of change
How Has This Been Tested?
Added 7 new test cases covering: truncated blocks (missing closing fence), incomplete JSON, orphan trailing fence, bare fence, multi-block + truncated combo, empty input, and CRLF line endings.
All 12 tests pass (5 existing + 7 new).
cd mem0-ts && npx jest --testPathPattern="remove-code-blocks"
Checklist:
Maintainer Checklist
removeCodeBlocksfails to strip markdown fences from truncated LLM responses #4401