fix: remove destructive vector_store.reset() from delete_all()#4349
Merged
kartik-mem0 merged 1 commit intomainfrom Mar 16, 2026
Merged
fix: remove destructive vector_store.reset() from delete_all()#4349kartik-mem0 merged 1 commit intomainfrom
kartik-mem0 merged 1 commit intomainfrom
Conversation
whysosaket
approved these changes
Mar 16, 2026
This was referenced Mar 20, 2026
Closed
jamebobob
pushed a commit
to jamebobob/mem0-vigil-recall
that referenced
this pull request
Mar 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
delete_all(user_id=...) is meant to delete only memories matching the provided filters. However, after deleting individual memories it called self.vector_store.reset(), which drops the entire
collection/table — destroying ALL memories regardless of the filter.
The async version of delete_all() already omits this call, confirming it was unintentional in the sync path.
Fixes #3785
Type of change
How Has This Been Tested?
Added regression assertion vector_store.reset.assert_not_called() to the existing test_delete_all test. Both parametrizations (v1.0/v1.1) pass.
Checklist:
Maintainer Checklist