fix: key error when llm omits entities key tool call#4313
Merged
kartik-mem0 merged 2 commits intomem0ai:mainfrom Mar 16, 2026
Merged
Conversation
whysosaket
approved these changes
Mar 16, 2026
jamebobob
pushed a commit
to jamebobob/mem0-vigil-recall
that referenced
this pull request
Mar 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a
KeyError: 'entities'crash in _retrieve_nodes_from_data when the LLM returns anextract_entitiestool call without theentitieskey in its arguments (e.g. for short inputs like "Hello.")Uses
safe .get()access with defaults instead of direct dictionary indexing across all four graph memoryimplementations:
graph_memory.py,kuzu_memory.py,memgraph_memory.py, andneptune/base.pyAdds test coverage for the missing-key scenario to
test_memgraph_memory.pyandtest_kuzu.py.Fixes #4312
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
memgraphandkuzutests passtest_missing_entities_key_returns_emptytests pass in both test filesTestRetrieveNodesFromDataclass intest_kuzu.pycovers happy path, missing key, and None tool_callsChecklist:
Maintainer Checklist