Merged
Conversation
Part of fixing OpenAIEmbedder ignoring custom base URLs (mirrors Python SDK fix for mem0ai#1144). The Zod schema already validates baseURL. This adds it to the TypeScript interface.
Previously the constructor only passed apiKey, causing all requests to default to api.openai.com. Now baseURL (with url as fallback) is forwarded, enabling custom endpoints like OpenRouter, Azure, and local providers.
Ensures baseURL is preserved when merging user config with defaults, so it reaches OpenAIEmbedder when using the Memory class.
deshraj
approved these changes
Mar 13, 2026
This was referenced Mar 13, 2026
Closed
jamebobob
pushed a commit
to jamebobob/mem0-vigil-recall
that referenced
this pull request
Mar 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The TypeScript SDK's
OpenAIEmbedderignores thebaseURLandurlconfiguration parameters, forcing all embedding requests toapi.openai.com. This breaks support for custom endpoints like OpenRouter, Azure, and local providers.This mirrors the fix already applied to the Python SDK (issue #1144)
Fixes #4268
Type of change
How Has This Been Tested?
Manually verified by instantiating
OpenAIEmbedderwithurl: "http://localhost:9999/v1"and callingembed(). Before the fix, the request defaulted toapi.openai.com. After the fix, the connection error confirms the request targetedlocalhost:9999/v1/embeddingsas expected.Checklist:
Maintainer Checklist