Skip to content

fix: disable ph telemetry still calls posthog#4203

Merged
whysosaket merged 3 commits intomem0ai:mainfrom
whysosaket:fix/fix-disable-telemetry
Mar 3, 2026
Merged

fix: disable ph telemetry still calls posthog#4203
whysosaket merged 3 commits intomem0ai:mainfrom
whysosaket:fix/fix-disable-telemetry

Conversation

@whysosaket
Copy link
Copy Markdown
Member

@whysosaket whysosaket commented Mar 2, 2026

This PR fixes an issue where the Posthog client was being instantiated even when telemetry was explicitly disabled via MEM0_TELEMETRY=False.

Although events were not being captured in this state, the client was still initialized unnecessarily, which could:

  • Create unwanted background threads

  • Initialize network-related resources

  • Increase startup overhead

  • Cause confusion when verifying telemetry is truly disabled

Copy link
Copy Markdown
Contributor

@MgeeeeK MgeeeeK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@whysosaket whysosaket merged commit 34c797d into mem0ai:main Mar 3, 2026
6 of 7 checks passed
@whysosaket whysosaket deleted the fix/fix-disable-telemetry branch March 3, 2026 22:25
jamebobob pushed a commit to jamebobob/mem0-vigil-recall that referenced this pull request Mar 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants