fix: accept default /tmp/chroma path in ChromaDbConfig validator#4179
Merged
kartik-mem0 merged 1 commit intomem0ai:mainfrom Mar 23, 2026
Merged
fix: accept default /tmp/chroma path in ChromaDbConfig validator#4179kartik-mem0 merged 1 commit intomem0ai:mainfrom
kartik-mem0 merged 1 commit intomem0ai:mainfrom
Conversation
VectorStoreConfig auto-sets path="/tmp/chroma" when no path is provided, but ChromaDbConfig explicitly excluded this path from valid local config, causing a ValueError. Remove the exclusion so the default path works.
|
|
Contributor
Author
|
Hi — just a gentle bump on this. Happy to make any changes if needed! |
Contributor
|
@kartik-mem0 / @whysosaket, the PR LGTM for merge Old code skipped counting /tmp/chroma as local so cloud + injected default path wouldn’t look like “cloud + local.” That broke real local configs that only had the default path. The fix: strip /tmp/chroma when cloud creds are set (unchanged), then treat any remaining path as local. Cloud still works; local default path validates. Verification |
kartik-mem0
approved these changes
Mar 23, 2026
jamebobob
pushed a commit
to jamebobob/mem0-vigil-recall
that referenced
this pull request
Mar 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When using the
chromavector store provider without explicitly setting apath,VectorStoreConfigauto-generatespath="/tmp/chroma". However,ChromaDbConfig.check_connection_configexplicitly excluded/tmp/chromafrom being considered a valid local configuration path, causing aValueError.The fix removes the
/tmp/chromaexclusion from thelocal_configcheck so the auto-generated default path is accepted. The cloud config path-stripping logic (which removes the auto-generated path when cloud credentials are provided) is unaffected.Fixes #3881
Type of change
How Has This Been Tested?
Added two tests:
test_chroma_config_accepts_default_tmp_path: verifiesChromaDbConfig(path="/tmp/chroma")succeedstest_chroma_config_rejects_no_config: verifiesChromaDbConfig()with no arguments still raisesValueErrorAll 17 chroma tests pass.
Checklist: