fix: upgrade MongoDB vector store from deprecated knnVector to GA vectorSearch#3995
Merged
kartik-mem0 merged 3 commits intomem0ai:mainfrom Mar 23, 2026
Merged
Conversation
Contributor
Author
|
Hi team -- friendly ping! This PR has been open for a couple of days without review. Would love any feedback when you get a chance. Thanks! |
Contributor
Author
|
Friendly ping - any chance someone could take a look at this when they get a chance? It's been open for about 10 days now. Happy to make any changes if needed. Thanks! |
…ration - Cap numCandidates to min(limit * 20, 10000) to respect MongoDB's hard upper limit - Update test assertions to match new vectorSearch index format - Update numCandidates assertion in test_search to reflect 20x multiplier Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
kartik-mem0
approved these changes
Mar 23, 2026
This was referenced Mar 23, 2026
jamebobob
pushed a commit
to jamebobob/mem0-vigil-recall
that referenced
this pull request
Mar 29, 2026
…torSearch (mem0ai#3995) Co-authored-by: kartik-mem0 <kartik.labhshetwar@mem0.ai> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3970
Upgrades the MongoDB vector store implementation from the deprecated
knnBeta/knnVectorindex syntax to the stable GAvectorSearchformat, as documented in the MongoDB Atlas migration guide.Changes
VECTOR_TYPE: Changed from"knnVector"(deprecated) to"vector"(GA)create_col): Replaced legacymappingsdefinition withtype="vectorSearch"andfieldslist format usingnumDimensionsinstead ofdimensionssearch): IncreasednumCandidatesfromlimit(identical to limit, poor recall) tolimit * 20(recommended 10-20x multiplier for HNSW indexes)Before (deprecated)
After (GA)
Test plan
type="vectorSearch"withfieldslist formatnumDimensionsinstead ofdimensionsnumCandidatesis set tolimit * 20for improved recallknnVectorreferences remain in the codebase