Skip to content

Fix embedder config schema to support embeddingDims and url parameters#3633

Merged
deshraj merged 1 commit intomem0ai:mainfrom
Mrinank-Bhowmick:fix/embedding
Oct 21, 2025
Merged

Fix embedder config schema to support embeddingDims and url parameters#3633
deshraj merged 1 commit intomem0ai:mainfrom
Mrinank-Bhowmick:fix/embedding

Conversation

@Mrinank-Bhowmick
Copy link
Copy Markdown
Contributor

The Zod schema for embedder config was missing embeddingDims and url fields, causing these parameters to be stripped during validation.

  • Added embeddingDims and url to MemoryConfigSchema.embedder.config
  • Updated ConfigManager.mergeConfig to pass embeddingDims

Fixes - #3632

Copy link
Copy Markdown
Contributor

@parshvadaftari parshvadaftari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@deshraj deshraj merged commit 5227b0a into mem0ai:main Oct 21, 2025
1 of 2 checks passed
@parshvadaftari
Copy link
Copy Markdown
Contributor

Thanks a lot for fixing and contributing to mem0 @Mrinank-Bhowmick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants