Description

Support for S3 Vectors was provided in v0.1.117. However, upon testing, it was found that initializing Memory via config with S3VectorConfig throws an AttributeError. Upon further investigation, turns out that S3VectorConfig contains the index_name attribute, while initializing Memory with config requires the collection_name attribute to be present in the config object.

This fix uses the collection_name attribute name to store the index name to be used within the S3 vector bucket. This aligns with the uniformity provided across other vector stores and their interaction with the Memory class.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• Documentation update

How Has This Been Tested?

• Unit Test

Test Details

• leveraged the existing tests/vector_stores/test_s3_vectors.py file
• added a test test_memory_initialization_with_config to ensure an AttributeException exception is not thrown while initializing Memory with an S3VectorConfig config, and confirm successful initialization of the Memory object

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules
• I have checked my code and corrected any misspellings

Strikethrough means 'Not Applicable'

Maintainer Checklist

• closes #xxxx (Replace xxxx with the GitHub issue number)
• Made sure Checks passed