fix: Use ConfigDict instead of class-based Config#3409
Merged
parshvadaftari merged 2 commits intomem0ai:mainfrom Sep 4, 2025
Merged
fix: Use ConfigDict instead of class-based Config#3409parshvadaftari merged 2 commits intomem0ai:mainfrom
parshvadaftari merged 2 commits intomem0ai:mainfrom
Conversation
Closes: mem0ai#3408 Branch: PydanticDeperecation-3408 Signed-off-by: Gabe Goodhart <ghart@us.ibm.com>
|
|
Contributor
parshvadaftari
left a comment
There was a problem hiding this comment.
Please incorporate the requested changes.
| import httpx | ||
| from pydantic import BaseModel, Field | ||
| from pydantic import BaseModel, ConfigDict, Field | ||
|
|
Contributor
There was a problem hiding this comment.
Can you update the class Config to ConfigDict everywhere. There are few other files as well. Thanks
Contributor
Author
There was a problem hiding this comment.
Ah! I just did a simple grep, sorry I missed those. I'll look further
Contributor
Author
|
Hm, it looks like the |
Contributor
|
@gabe-l-hart you can remove the changes in the embedchain. Keep for the mem0ai and openmemory only. |
This consolidates the two old ways of setting the pydantic model config (class-based and raw dict) into the official ConfigDict method. mem0ai#3408 Branch: PydanticDeperecation-3408 Signed-off-by: Gabe Goodhart <ghart@us.ibm.com>
d9c8f00 to
e2cefb8
Compare
Contributor
Author
|
Ok, looks like everything besides the Vercel login is passing now |
Contributor
|
@gabe-l-hart Thanks for the contribution! |
Contributor
Author
|
Thanks for the review! |
turtlebasket
referenced
this pull request
in turtlebasket/mem0x
Sep 5, 2025
Signed-off-by: Gabe Goodhart <ghart@us.ibm.com> (cherry picked from commit b27879b)
thestumonkey
pushed a commit
to Ushadow-io/mem0
that referenced
this pull request
Sep 7, 2025
Signed-off-by: Gabe Goodhart <ghart@us.ibm.com>
jamebobob
pushed a commit
to jamebobob/mem0-vigil-recall
that referenced
this pull request
Mar 29, 2026
Signed-off-by: Gabe Goodhart <ghart@us.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This updates the
openmemory.api.app.schemas.Memoryandmem0.client.project.ProjectConfigpydantic classes to use the modernConfigDictstyle rather thanclass Config:.Fixes #3408
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Before
After
NOTE: Since this is a small patch, I didn't get the full dev environment off the ground (I'm not normally a
hatchuser). If CI fails, I'm happy to put in the extra minutes to get it clean locally.Checklist:
Maintainer Checklist