Enhancement/Action tests#292
Merged
meili-bors[bot] merged 3 commits intomainfrom Dec 13, 2022
Merged
Conversation
alallema
previously approved these changes
Dec 5, 2022
Contributor
alallema
left a comment
There was a problem hiding this comment.
Well Done @brunoocasali thank again to take care of this repo ❤️
LGTM!
Contributor
|
bors merge |
meili-bors Bot
added a commit
that referenced
this pull request
Dec 5, 2022
292: Enhancement/Action tests r=alallema a=brunoocasali Fixes #290 I think we can keep the last three minor releases of Python. This PR adds those last three minors to `unit_tests` and `integration_tests` actions. The linter action runs only against the python version we have in the final docker image. Co-authored-by: Bruno Casali <brunoocasali@gmail.com> Co-authored-by: Amélie <alallema@users.noreply.github.com>
Contributor
|
Timed out. |
Member
Author
|
bors merge |
meili-bors Bot
added a commit
that referenced
this pull request
Dec 5, 2022
292: Enhancement/Action tests r=brunoocasali a=brunoocasali Fixes #290 I think we can keep the last three minor releases of Python. This PR adds those last three minors to `unit_tests` and `integration_tests` actions. The linter action runs only against the python version we have in the final docker image. Co-authored-by: Bruno Casali <brunoocasali@gmail.com> Co-authored-by: Amélie <alallema@users.noreply.github.com>
Contributor
|
Timed out. |
Contributor
|
bors merge |
meili-bors Bot
added a commit
that referenced
this pull request
Dec 6, 2022
292: Enhancement/Action tests r=bidoubiwa a=brunoocasali Fixes #290 I think we can keep the last three minor releases of Python. This PR adds those last three minors to `unit_tests` and `integration_tests` actions. The linter action runs only against the python version we have in the final docker image. Co-authored-by: Bruno Casali <brunoocasali@gmail.com> Co-authored-by: Amélie <alallema@users.noreply.github.com>
Contributor
|
Timed out. |
Contributor
|
Contributor
|
We could try to run the tests locally on a python 3.8 environment |
Collaborator
|
Python 3.8 was removed from the test matrix, but it's still required in the |
Member
Author
well spotted @sanders41 thanks! |
alallema
approved these changes
Dec 13, 2022
Contributor
|
bors merge |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #290
I think we can keep the last three minor releases of Python. This PR adds those last three minors to
unit_testsandintegration_testsactions.The linter action runs only against the python version we have in the final docker image.