feat(#94): add creator attribution + update footer socials#95
Merged
Conversation
Two additions to the landing so apexyard has a human face and a discoverable trail back to the creator's other work. 1. Hero attribution line immediately under the tagline: "Built by me2resh" where "me2resh" links to me2resh.com. Small uppercase monospace (12px, --ink-faint), accent-coloured on hover. Tagline margin tightened from 1rem to 0.4rem so the new line sits visually joined to the tagline rather than floating. 2. Footer refresh. Left span swaps the generic "apexyard v1.0 · MIT · plain markdown · zero dependencies" brand line for the attribution: "Built by me2resh · MIT · plain markdown · zero dependencies" (drops v1.0 - already shown in the hero eyebrow + version badge). Right span adds twitter + blog to the existing github link: "github · twitter · blog". Removed the issues + prs links because they're duplicated in the "final" CTA block just above the footer and the social-style footer reads cleaner without them. Footer link styling now has an explicit 1px underline so anchors look clickable; existing hover-to-accent behaviour kept. role contentinfo landmark added for a11y. No CSP change needed - me2resh.com, github.com, twitter.com are navigation targets not resource fetches, outside CSP's remit. All external links carry target="_blank" rel="noopener". Closes #94
✅ Deploy Preview for apexyard ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
atlas-apex
commented
Apr 19, 2026
atlas-apex
left a comment
Collaborator
Author
There was a problem hiding this comment.
Code Review: PR #95
Commit: 62e64d3c1e808ab3ecc2ab194475a6e545a664e1
Summary
Small UI-only change to site/index.html: adds a hero attribution line under the tagline ("Built by me2resh", monospace caps, --ink-faint) and refreshes the footer (swapped brand line, replaced issues/prs links with twitter/blog, added role="contentinfo", explicit 1px underline on footer links). Tagline margin-bottom tightened from 1rem → 0.4rem so the new attribution sits visually glued to the tagline.
Checklist Results
- Architecture & Design: N/A (single-file static landing)
- Code Quality: Pass
- Testing: N/A (UI-only; Netlify preview is the verification surface)
- Security: Pass
- Performance: Pass (+38 lines of inline CSS/HTML, no new fetches)
- PR Description & Glossary: Pass (5 substantive terms)
- Technical Decisions (AgDR): N/A (no new libraries, frameworks, patterns, or architectural decisions — a content + presentation diff)
Issues Found
None.
Verification Notes
- CSP: Triple-checked. The
netlify.tomlCSP coversscript-src,style-src,font-src,img-src,connect-src,frame-ancestors,base-uri,form-action. None of these govern<a href>navigation targets — CSP intentionally does not gate outbound navigation (nonavigate-todirective is in effect here). The three new external href hosts (me2resh.com,twitter.com/me2resh,github.com/me2resh) are navigation targets, not resource fetches. No CSP update required. The PR body and ticket #94 call this out correctly. - Tabnabbing hygiene: All four outbound links have
target="_blank" rel="noopener"— hero attribution, footer left "me2resh", and footer right github/twitter/blog. ✓ - Mobile render: Hero attribution is 12px monospace caps with
letter-spacing: 0.08em; the text "BUILT BY ME2RESH" is ~15 characters, well inside the 60ch parent width even on 320px. The.rise-3class matches the existing hero__sub reveal stagger, so the new line animates in on the same beat as the sub. Layout-safe. role="contentinfo": Correctly placed on the<footer>element. Technically redundant since a<footer>as a direct child of<body>already exposes an implicitcontentinfolandmark, but harmless and matches the AC from #94.- Link styling consistency: New hero attribution and updated footer links both use the same 1px border-bottom underline + hover-swap-to-
--accentpattern already established elsewhere on the page. Good brand consistency. - CI: Netlify preview + Header rules + Redirect rules + Verify Ticket ID + lychee all green. "Pages changed" skipped (expected — no markdown mutation).
- Ticket: #94 is open, labeled
enhancement, and the PR delivers exactly what the ACs asked for including the CSP androle="contentinfo"notes.
Suggestions (non-blocking)
- If you ever want to suppress the redundant
role="contentinfo"on a future a11y-lint pass, it's safe to drop — but equally safe to keep as a belt-and-braces signal. Not worth changing now.
Verdict
APPROVED
Reviewed by Rex (Code Reviewer Agent)
Reviewed commit: 62e64d3c1e808ab3ecc2ab194475a6e545a664e1
me2resh
approved these changes
Apr 19, 2026
me2resh
approved these changes
Apr 19, 2026
osama-abu-baker
pushed a commit
to osama-abu-baker/apexyard
that referenced
this pull request
Jun 3, 2026
…2resh#95) Two additions to the landing so apexyard has a human face and a discoverable trail back to the creator's other work. 1. Hero attribution line immediately under the tagline: "Built by me2resh" where "me2resh" links to me2resh.com. Small uppercase monospace (12px, --ink-faint), accent-coloured on hover. Tagline margin tightened from 1rem to 0.4rem so the new line sits visually joined to the tagline rather than floating. 2. Footer refresh. Left span swaps the generic "apexyard v1.0 · MIT · plain markdown · zero dependencies" brand line for the attribution: "Built by me2resh · MIT · plain markdown · zero dependencies" (drops v1.0 - already shown in the hero eyebrow + version badge). Right span adds twitter + blog to the existing github link: "github · twitter · blog". Removed the issues + prs links because they're duplicated in the "final" CTA block just above the footer and the social-style footer reads cleaner without them. Footer link styling now has an explicit 1px underline so anchors look clickable; existing hover-to-accent behaviour kept. role contentinfo landmark added for a11y. No CSP change needed - me2resh.com, github.com, twitter.com are navigation targets not resource fetches, outside CSP's remit. All external links carry target="_blank" rel="noopener". Closes me2resh#94 Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
mosta7il
pushed a commit
to mosta7il/apexyard
that referenced
this pull request
Jun 8, 2026
…2resh#95) Two additions to the landing so apexyard has a human face and a discoverable trail back to the creator's other work. 1. Hero attribution line immediately under the tagline: "Built by me2resh" where "me2resh" links to me2resh.com. Small uppercase monospace (12px, --ink-faint), accent-coloured on hover. Tagline margin tightened from 1rem to 0.4rem so the new line sits visually joined to the tagline rather than floating. 2. Footer refresh. Left span swaps the generic "apexyard v1.0 · MIT · plain markdown · zero dependencies" brand line for the attribution: "Built by me2resh · MIT · plain markdown · zero dependencies" (drops v1.0 - already shown in the hero eyebrow + version badge). Right span adds twitter + blog to the existing github link: "github · twitter · blog". Removed the issues + prs links because they're duplicated in the "final" CTA block just above the footer and the social-style footer reads cleaner without them. Footer link styling now has an explicit 1px underline so anchors look clickable; existing hover-to-accent behaviour kept. role contentinfo landmark added for a11y. No CSP change needed - me2resh.com, github.com, twitter.com are navigation targets not resource fetches, outside CSP's remit. All external links carry target="_blank" rel="noopener". Closes me2resh#94 Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Gives apexyard a human face:
twitter+blogto the existinggithublink (drops theissues+prslinks that are already in the "final" CTA block just above).Tagline bottom margin tightened (
1rem → 0.4rem) so the attribution sits visually glued to the tagline rather than floating as a separate paragraph.Testing
Where projects get forged.→BUILT BY ME2RESHin small monospace caps with an underline on "me2resh". Hover turns it red (--accent).Built by me2resh · MIT · plain markdown · zero dependencieson the left;github · twitter · blogon the right. All four links open in a new tab.Closes #94
Glossary
role="contentinfo"target="_blank" rel="noopener"window.openerreference, preventing the new tab's page from manipulating the opener'swindow.location. Standard hygiene for any outbound link.connect-src/script-src/ etc. govern resource fetches (XHR, script loads, stylesheet loads). Plain<a href>navigation that leaves the page is outside CSP's remit — no policy update needed when adding outbound links.