Skip to content

fix(#42): CI — markdown lint auto-fix and lycheeignore for private repos#44

Merged
atlas-apex merged 1 commit into
mainfrom
fix/#42-ci-fixes-clean
Apr 12, 2026
Merged

fix(#42): CI — markdown lint auto-fix and lycheeignore for private repos#44
atlas-apex merged 1 commit into
mainfrom
fix/#42-ci-fixes-clean

Conversation

@atlas-apex

Copy link
Copy Markdown
Collaborator

Summary

  • Run markdownlint-cli2 --fix across all .md files — fixes MD022/MD032 blank-line violations in 40 files
  • Add .lycheeignore to exclude private portfolio repo links from unauthenticated link checks

Test plan

  • Markdown Lint CI check passes
  • Link Check CI check passes (transient network errors excluded)

Glossary

Term Definition
MD022 markdownlint rule requiring blank lines around headings
MD032 markdownlint rule requiring blank lines around lists
.lycheeignore File listing URL patterns the lychee link checker should skip

Generated with Claude Code

- Run markdownlint-cli2 --fix on all .md files (MD022, MD032 blank-line violations)
- Add .lycheeignore to exclude private portfolio repo links from unauthenticated checks

Closes #42

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

@atlas-apex atlas-apex left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review: PR #44

Commit: 4164825cbe9c6473bb3f8281cc65b45e209fa7d6

Summary

This PR auto-fixes MD022/MD032 markdown lint violations (blank lines around headings and lists) across 40 files, and adds a .lycheeignore file to suppress false-positive link check failures for private/portfolio GitHub repos. All changes are additive (173 additions, 0 deletions) — every change is a blank line insertion to satisfy markdownlint rules.

Checklist Results

  • N/A Architecture & Design: No code changes — markdown docs only
  • PASS Code Quality: Auto-fixer output is consistent and correct
  • N/A Testing: No testable code changed
  • PASS Security: No secrets, no code, no injection surface
  • N/A Performance: Markdown-only changes
  • PASS PR Description & Glossary: Summary, test plan, and glossary all present. Terms (MD022, MD032, .lycheeignore) defined clearly.
  • N/A Technical Decisions (AgDR): No technical decisions — this is a lint auto-fix pass

Issues Found

None blocking.

Suggestions (non-blocking)

  1. templates/prd.md — empty blockquote lines: The auto-fixer added bare > lines between headings and blockquote content in the User Stories section (lines 43 and 55 in the patched file). This renders as an empty blockquote paragraph above the user story text. It satisfies MD022 but is slightly odd semantically. Consider replacing the bare > with just a blank line if markdownlint can be satisfied another way — or leave it as-is since it is cosmetically minor.

  2. .lycheeignore — broad patterns: The regex https://github.com/me2resh/apexstack.* will match any URL that starts with that prefix, including hypothetical subpaths of other repos that share the prefix. This is fine today but worth noting if the org adds repos with overlapping name prefixes.

  3. handover/SKILL.md — blank lines inside fenced code blocks: The auto-fixer added blank lines inside fenced code blocks (around the "Ready to add {name}" prompt). These are harmless but add empty lines in the rendered code block output. Non-issue.

Verdict

APPROVED — Clean, mechanical lint fix. All CI checks passing (markdownlint, lychee, shellcheck, PR title). No functional changes, no security concerns, no technical decisions requiring AgDR.


Reviewed by Rex (Code Reviewer Agent)
Reviewed commit: 4164825cbe9c6473bb3f8281cc65b45e209fa7d6

@atlas-apex atlas-apex merged commit 21eb621 into main Apr 12, 2026
4 checks passed
osama-abu-baker pushed a commit to osama-abu-baker/apexyard that referenced this pull request Jun 3, 2026
fix(me2resh#42): CI — markdown lint auto-fix and lycheeignore for private repos
@me2resh me2resh deleted the fix/#42-ci-fixes-clean branch June 5, 2026 16:52
mosta7il pushed a commit to mosta7il/apexyard that referenced this pull request Jun 8, 2026
fix(me2resh#42): CI — markdown lint auto-fix and lycheeignore for private repos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants